Skip to content

ATL-941: Fixed recursive folder issue on Save as #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2021

Conversation

kittaakos
Copy link
Contributor

@kittaakos kittaakos commented Mar 12, 2021

This PR fixes the recursive folder creation on non-POSIX filesystems when saving a sketch as anything into the current sketch folder. Unlike the Java IDE, the new IDE does not prevent the entire Save As... operation; one can save a sketch as anything into the current sketch folder. Please review.

Closes #65.

Signed-off-by: Akos Kitta [email protected]

@kittaakos kittaakos requested a review from per1234 March 12, 2021 13:41
@ubidefeo
Copy link

@per1234 @rsora
if any of you can review on windows that'd be great

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am able to reproduce #65 with the current nightly.
I am not able to reproduce #65 with the build from this PR.

Thanks Akos!

@kittaakos kittaakos merged commit 9cd9146 into main Mar 15, 2021
@kittaakos kittaakos deleted the atl-941--fix-save-as-in-current-sketch branch March 15, 2021 08:15
@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Saving inside currently open sketch generates 257 nested folders
3 participants