Skip to content

#1366 Buffer events from BoardListWatchResponse #1379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

kittaakos
Copy link
Contributor

Motivation

Hopefully, the board reconnecting issue is fixed for the teensy port protocol.

Change description

  • Buffered the DetectedPort 'add'/'remove' events retrieved from the BoardListWatchResponsees to calculate a correct AttachedBoardsChangeEvent for the IDE2 frontend. If a board was detected to be removed and added in a short period, the discovery service would treat the events as a NOOP.
  • Removed the board discovery stop/start guard when refreshing (InitRequest) the gRPC core client after the library/platform index updates. This will ensure that already discovered boards/ports won't be re-discovered. The force stop/start guard can be removed as [breaking] daemon: Fix concurrency and streamline access to PackageManager arduino-cli#1828 solved it on the CLI side, so no external guard is required from IDE2.

Other information

Closes #1366

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@kittaakos kittaakos added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Sep 1, 2022
@kittaakos kittaakos requested a review from per1234 September 1, 2022 10:18
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested with the build from 417d95f and it does not fix #1366

@kittaakos
Copy link
Contributor Author

Is part of #2149. Closing as a duplicate.

@kittaakos kittaakos closed this Jul 21, 2023
@kittaakos kittaakos added the conclusion: duplicate Has already been submitted label Jul 21, 2023
@per1234 per1234 deleted the #1366 branch August 1, 2023 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: duplicate Has already been submitted topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Selection of port lost on upload when protocol other than serial/network and no "recognized" board
2 participants