Skip to content

Remove unnecessary board discovery stop/start guard arounds lib/platform install/uninstall commands #1389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
3 tasks done
kittaakos opened this issue Sep 3, 2022 · 0 comments
Open
3 tasks done

Remove unnecessary board discovery stop/start guard arounds lib/platform install/uninstall commands #1389

kittaakos opened this issue Sep 3, 2022 · 0 comments
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Comments

@kittaakos
Copy link
Contributor

kittaakos commented Sep 3, 2022 •
edited
Loading

Describe the request

The CLI is taking care of the synchronization of the packages (arduino/arduino-cli#1828). IDE2 can eliminate the external "synchronization" (board discovery stop/start) when installing/uninstalling libs or platforms.

IDE2 code can be cleaned up, unnecessary dependency removed, plus it helps calculate a correct gRPC equivalent of board list -w delta for the frontend (see related: #1379).

Describe the current behavior

IDE2 stops/starts the board discovery guarding against concurrency issues (#674) when installing/uninstalling libs/platforms.

Arduino IDE version

20cc34c

Operating system

macOS

Operating system version

12.5.1

Additional context

This is not a functional bug. Indeed IDE2 will get rid of the unnecessary discovery stop/start after the code cleanup.

Issue checklist

  • I searched for previous requests in the issue tracker
  • I verified the feature was still missing when using the latest nightly build
  • My request contains all necessary details
@kittaakos kittaakos added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Sep 3, 2022
@kittaakos kittaakos self-assigned this Sep 3, 2022
@kittaakos kittaakos changed the title [dev] Remove unnecessary board discovery stop/start from lib/platform install/uninstall Remove unnecessary board discovery stop/start from lib/platform install/uninstall Sep 3, 2022
@kittaakos kittaakos changed the title Remove unnecessary board discovery stop/start from lib/platform install/uninstall Remove unnecessary board discovery stop/start guard around lib/platform install/uninstall commands Sep 3, 2022
@kittaakos kittaakos changed the title Remove unnecessary board discovery stop/start guard around lib/platform install/uninstall commands Remove unnecessary board discovery stop/start guard arounds lib/platform install/uninstall commands Sep 3, 2022
@kittaakos kittaakos mentioned this issue Dec 11, 2023
Closed
3 tasks
@kittaakos kittaakos removed their assignment Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kittaakos