Skip to content

Toolbar enhancements #1194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 29 commits into from
Jul 18, 2022
Merged

Toolbar enhancements #1194

merged 29 commits into from
Jul 18, 2022

Conversation

francescospissu
Copy link
Contributor

Motivation

The toolbar needs to be updated with new icons, different sizes and other graphical improvements to reflect the new design system.

Change description

Graphic updates based on new specifications.

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

francescospissu and others added 19 commits July 18, 2022 12:54
@francescospissu francescospissu force-pushed the fspissu/toolbar-update branch from 440ccd2 to 6bd2aef Compare July 18, 2022 11:01
@francescospissu francescospissu marked this pull request as ready for review July 18, 2022 12:21
AlbyIanna
AlbyIanna suggested changes Jul 18, 2022
View reviewed changes
Copy link
Contributor

@AlbyIanna AlbyIanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it's good, nice job!
I've just made some suggestions to have a cleaner code (in particular the CSS)

francescospissu and others added 2 commits July 18, 2022 16:12
@francescospissu
Update arduino-frontend-contribution.tsx
6da5945 
Co-authored-by: Alberto Iannaccone <[email protected]>
@francescospissu
Remove useless properties
0ce49a6 
Co-authored-by: Alberto Iannaccone <[email protected]>
AlbyIanna
AlbyIanna approved these changes Jul 18, 2022
View reviewed changes
Copy link
Contributor

@AlbyIanna AlbyIanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

Look at this wonderful new UI 🤩

LGTM 🚀

@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Jul 18, 2022
@francescospissu francescospissu merged commit 5ff9ce0 into main Jul 18, 2022
@francescospissu francescospissu deleted the fspissu/toolbar-update branch July 18, 2022 16:43
@per1234 per1234 linked an issue Aug 3, 2022 that may be closed by this pull request
Verify and Upload buttons do not change colour when activated. #173
Closed
@per1234 per1234 mentioned this pull request Aug 3, 2022
Closed
kittaakos pushed a commit to kittaakos/arduino-ide that referenced this pull request Aug 17, 2022
Removed unused New, Save, and Open logic.
3571032 
The icons were removed in arduino#1194.

Signed-off-by: Akos Kitta <[email protected]>
@per1234 per1234 mentioned this pull request Aug 25, 2022
Closed
3 tasks
@per1234 per1234 mentioned this pull request Nov 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fstasi fstasi fstasi approved these changes

@AlbyIanna AlbyIanna AlbyIanna approved these changes

@91volt 91volt 91volt approved these changes

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Verify and Upload buttons do not change colour when activated.
5 participants
@francescospissu @fstasi @AlbyIanna @91volt @per1234