-
-
Notifications
You must be signed in to change notification settings - Fork 431
IDE startup theme based on OS theme #1160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This should work: fspissu/startup-theme...kittaakos:arduino-ide:startup-theme-2. Update: I think the long-term goal is to support dark and light themes in Theia natively and not customize the |
Thanks for your support @kittaakos. In a later step I can create a contribution on Theia to achieve this directly there. |
Signed-off-by: Akos Kitta <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I did not check the behavior but the code changes look good to me.
Could you please ask the Theia community why we need this hack?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice hack 😎
I tested it on MacOS and it works perfectly.
LGTM 🚀
Motivation
The theme of the IDE on first launch should be the same as the OS.
Change description
Implemented a patch that replaces the
ThemeService.get().loadUserTheme();
function at startup by directly setting the theme based on the OS theme.For all subsequent starts of the IDE the theme applied will be the last one set by the user.
Other information
With the current version of Theia adopted (1.25) it is not possible to extend the
ThemeService
, it will be possible starting from Theia 1.27.Once the version of Theia is updated, this patch will be removed and this functionality will be implemented via dependency injection.
Closes #530.
Reviewer checklist