Skip to content

Sync theme with system dynamically #1338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks done
theonlytechnohead opened this issue Aug 20, 2022 · 4 comments
Closed
3 tasks done

Sync theme with system dynamically #1338

theonlytechnohead opened this issue Aug 20, 2022 · 4 comments
Assignees
Labels
conclusion: declined Will not be worked on topic: code Related to content of the project itself topic: theme Related to GUI theming type: enhancement Proposed improvement

Comments

@theonlytechnohead
Copy link

Describe the request

It would be great to be able to 'sync' the theme with the system's theme. For example:
Windows Light mode Apps: Arduino (Light) theme
Windows Dark mode Apps: Arduino (Dark) theme

The preferences screen would need an option to enable/disable sync, and separate choices for Light and Dark themes

IntelliJ IDEs have this feature, as such:
image

Describe the current behavior

A single theme can be chosen at one time.

Arduino IDE version

2.0.0-rc9.2.nightly-20220819

Operating system

Windows, Linux, macOS

Operating system version

Windows 10 64-bit 21H1 (19043)

Additional context

No response

Issue checklist

  • I searched for previous requests in the issue tracker
  • I verified the feature was still missing when using the latest nightly build
  • My request contains all necessary details
@theonlytechnohead theonlytechnohead added the type: enhancement Proposed improvement label Aug 20, 2022
@per1234
Copy link
Contributor

per1234 commented Aug 20, 2022

Hi @theonlytechnohead. Thanks for your suggestion.

Something similar was added recently: #1160

This causes the IDE to set the theme preference according to the OS theme on the first run. Since the IDE does not make change to the user's preferences once they have been initialized, you would not have noticed any effect from this change if you were already using the Arduino IDE before the introduction of the feature at ed41b25 or the 2.0.0-rc9 release.

Since I think #1160 adequately covers this requirement, I will close this as resolved.

@per1234 per1234 closed this as not planned Won't fix, can't repro, duplicate, stale Aug 20, 2022
@per1234 per1234 self-assigned this Aug 20, 2022
@per1234 per1234 added conclusion: declined Will not be worked on topic: code Related to content of the project itself topic: theme Related to GUI theming labels Aug 20, 2022
@Logicer16
Copy link

Since I think #1160 adequately covers this requirement, I will close this as resolved.

@per1234 #1160 only matches the system theme on the program's first launch. Beyond that, the theme will be static until a user changes it, assuming a workbench.colorTheme entry exists in .settings.json.

To sync the theme with the system implies that when the system's theme changes, the program's theme would also change to match. This means this issue concerns more than just the first launch and is probably outside the scope of #1160.

@per1234
Copy link
Contributor

per1234 commented Sep 3, 2022

I understand. That is why I said "adequately". The user is responsible for any theme changes they want made after the first run.

We will not invest development resources into dynamic theme changes because there are higher priorities.

@Logicer16
Copy link

Logicer16 commented Sep 3, 2022

I can also see that this issue is very much a "nice to have" rather than a necessity. But at the same time, this project is open source. Even if someone part of Arduino won't end up doing it, it would make more sense to leave it open, mentioning the situation, for someone else looking to contribute to the project rather than closing it and labelling it as declined with other issues that probably won't ever be resolved.

I'll also understand if the answer is no for keeping track of the issue that really needs to be fixed

@per1234 per1234 changed the title Sync theme with system Sync theme with system dynamically Jun 18, 2023
@per1234 per1234 mentioned this issue Mar 21, 2025
3 tasks
@per1234 per1234 marked this as a duplicate of #2662 Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: declined Will not be worked on topic: code Related to content of the project itself topic: theme Related to GUI theming type: enhancement Proposed improvement
Projects
None yet
Development

No branches or pull requests

3 participants