Skip to content

Menu item "Edit > Select All" only select 10 lines of code #969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
ubidefeo opened this issue Apr 25, 2022 · 3 comments
Closed
3 tasks done

Menu item "Edit > Select All" only select 10 lines of code #969

ubidefeo opened this issue Apr 25, 2022 · 3 comments
Assignees
@kittaakos
Labels
conclusion: resolved Issue was resolved criticality: medium Of moderate impact os: macos Specific to macOS operating system topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Comments

@ubidefeo
Copy link

Describe the problem

When wanting to select all the code in the current tab, if using the CMD+A shortcut it is correctly selected,
while using the menu item will only select 10 lines and it's not really clear where the starting point is, because the selection begin/end are offset from the last cursor position

To reproduce

  • open a Sketch
  • place your cursor in the code window
  • from the application menu Edit > Select All
  • unselect by clicking in an unselected part of the text
  • only 10 lines will be selected
  • use the shortcut CMD+A (CTRL+A on Windows)
  • the entire code will be selected

CleanShot 2022-04-25 at 15 36 05@2x

CleanShot 2022-04-25 at 15 36 50@2x

Expected behavior

The entire code in the current tab should be selected and ready to be acted upon

Arduino IDE version

2.0.0-rc6

Operating system

macOS

Operating system version

12.3

Additional context

No response

Issue checklist

  • I searched for previous reports in the issue tracker
  • I verified the problem still occurs when using the latest nightly build
  • My report contains all necessary details
@ubidefeo ubidefeo added type: imperfection Perceived defect in any part of project criticality: medium Of moderate impact topic: code Related to content of the project itself labels Apr 25, 2022
@ubidefeo ubidefeo assigned msujew and unassigned AlbyIanna May 4, 2022
@kittaakos kittaakos assigned kittaakos and unassigned msujew Jun 3, 2022
kittaakos pushed a commit that referenced this issue Jun 3, 2022
Disabled MenuItem roles on macOS.
946ed5a 
Closes #969
Upstream-ref: eclipse-theia/theia#11217

Signed-off-by: Akos Kitta <[email protected]>
@kittaakos
Copy link
Contributor

PR: #1022. Please review. Thank you!

@fstasi fstasi closed this as completed Jun 8, 2022
@kittaakos kittaakos reopened this Jun 8, 2022
@kittaakos
Copy link
Contributor

The PR is not merged. I have reopened this issue.

kittaakos pushed a commit that referenced this issue Jun 8, 2022
Disabled MenuItem roles on macOS.
dc65a78 
Closes #969
Upstream-ref: eclipse-theia/theia#11217

Signed-off-by: Akos Kitta <[email protected]>
@kittaakos kittaakos mentioned this issue Jun 22, 2022
Merged
4 tasks
@ubidefeo
Copy link
Author

Tested PR and approved

@per1234 per1234 added conclusion: resolved Issue was resolved os: macos Specific to macOS operating system labels Jun 22, 2022
kittaakos pushed a commit to kittaakos/arduino-ide that referenced this issue Apr 25, 2023
fix: restore menu roles
87a18fe 
otherwise cannot copy+paste in editor on macOS?

arduino#969

Signed-off-by: Akos Kitta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kittaakos kittaakos

Labels
conclusion: resolved Issue was resolved criticality: medium Of moderate impact os: macos Specific to macOS operating system topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@kittaakos @fstasi @ubidefeo @msujew @AlbyIanna @per1234