fix: restore menu roles

otherwise cannot copy+paste in editor on macOS?

arduino#969

Signed-off-by: Akos Kitta <[email protected]>

Author: Akos Kitta

Diff for: arduino-ide-extension/src/electron-browser/theia/core/electron-main-menu-factory.ts

@@ -14,10 +14,7 @@ import {
   ElectronMenuOptions,
   ElectronMainMenuFactory as TheiaElectronMainMenuFactory,
 } from '@theia/core/lib/electron-browser/menu/electron-main-menu-factory';
-import type {
-  MenuDto,
-  MenuRole,
-} from '@theia/core/lib/electron-common/electron-api';
+import type { MenuDto } from '@theia/core/lib/electron-common/electron-api';
 import { inject, injectable } from '@theia/core/shared/inversify';
 import {
   ArduinoMenus,
@@ -136,15 +133,6 @@ export class ElectronMainMenuFactory extends TheiaElectronMainMenuFactory {
     return { label, submenu };
   }
 
-  // eslint-disable-next-line @typescript-eslint/no-unused-vars, unused-imports/no-unused-vars
-  protected override roleFor(id: string): MenuRole | undefined {
-    // MenuItem `roles` are completely broken on macOS:
-    //  - https://github.com/eclipse-theia/theia/issues/11217,
-    //  - https://github.com/arduino/arduino-ide/issues/969
-    // IDE2 uses commands instead.
-    return undefined;
-  }
-
   protected override fillMenuTemplate(
     parentItems: MenuDto[],
     menuModel: MenuNode,