Skip to content

Implementation of port discovery through Pluggable discovery #900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Mar 20, 2024

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Feb 12, 2024

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • Tests for the changes have been added (for bug fixes / features)
  • What kind of change does this PR introduce?
    The port discovery is offloaded from the agent and it's made available through pluggable-discoveries (as done other Arduino software products like Arduino IDE or Arduino CLI)
  • What is the current behavior?
    The port discovery subroutine was embedded in the Create Agent (leading to code duplication and double maintenance effort)
  • What is the new behavior?
    The port discovery subroutine is off-loaded to pluggable discvoeries.
  • Does this PR introduce a breaking change?
    No

@cmaglie cmaglie self-assigned this Feb 12, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2024

Codecov Report

Attention: Patch coverage is 1.53846% with 128 lines in your changes are missing coverage. Please review.

Project coverage is 20.90%. Comparing base (ef266fa) to head (36bdf7b).

Files Patch % Lines
serial.go 0.00% 113 Missing ⚠️
main.go 0.00% 9 Missing ⚠️
serialport.go 0.00% 4 Missing ⚠️
conn.go 0.00% 1 Missing ⚠️
hub.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #900      +/-   ##
==========================================
+ Coverage   20.89%   20.90%   +0.01%     
==========================================
  Files          43       42       -1     
  Lines        3164     3157       -7     
==========================================
- Hits          661      660       -1     
+ Misses       2406     2400       -6     
  Partials       97       97              
Flag Coverage Δ
unit 20.90% <1.53%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmaglie cmaglie mentioned this pull request Feb 12, 2024
2 tasks
@cmaglie cmaglie linked an issue Feb 12, 2024 that may be closed by this pull request
@cmaglie cmaglie force-pushed the pluggable_discovery branch from 584a79e to 689037d Compare February 12, 2024 14:08
@cmaglie cmaglie requested a review from a team February 12, 2024 14:18
@cmaglie cmaglie added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Feb 12, 2024
@cmaglie cmaglie force-pushed the pluggable_discovery branch from 689037d to a7d97e7 Compare February 12, 2024 16:37
@cmaglie cmaglie force-pushed the pluggable_discovery branch from eee5b0b to 36bdf7b Compare March 20, 2024 11:35
@cmaglie cmaglie merged commit 5e37994 into main Mar 20, 2024
48 checks passed
@cmaglie cmaglie deleted the pluggable_discovery branch March 20, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement discovery protocol
4 participants