-
-
Notifications
You must be signed in to change notification settings - Fork 150
Implementation of port discovery through Pluggable discovery #900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #900 +/- ##
==========================================
+ Coverage 20.89% 20.90% +0.01%
==========================================
Files 43 42 -1
Lines 3164 3157 -7
==========================================
- Hits 661 660 -1
+ Misses 2406 2400 -6
Partials 97 97
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
584a79e
to
689037d
Compare
689037d
to
a7d97e7
Compare
cmaglie
commented
Feb 12, 2024
alessio-perugini
requested changes
Feb 12, 2024
umbynos
suggested changes
Feb 15, 2024
alessio-perugini
approved these changes
Feb 26, 2024
umbynos
approved these changes
Feb 27, 2024
eee5b0b
to
36bdf7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
The port discovery is offloaded from the agent and it's made available through pluggable-discoveries (as done other Arduino software products like Arduino IDE or Arduino CLI)
The port discovery subroutine was embedded in the Create Agent (leading to code duplication and double maintenance effort)
The port discovery subroutine is off-loaded to pluggable discvoeries.
No
Supersedes Enable pluggable discovery #773