Skip to content

Enable pluggable discovery #773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Enable pluggable discovery #773

wants to merge 2 commits into from

Conversation

umbynos
Copy link
Contributor

@umbynos umbynos commented Mar 3, 2023

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • Tests for the changes have been added (for bug fixes / features)
  • What kind of change does this PR introduce?

Implement the pluggable discovery protocol of the Arduino CLI

  • What is the current behavior?

The logic of the serial and mdns discovery is hardcoded in the codebase.

  • What is the new behavior?

Pluggable discoveries are used

  • Does this PR introduce a breaking change?

It shouldn't

  • Other information:

@umbynos umbynos changed the title enable pluggable Enable pluggable discovery Mar 3, 2023
@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Mar 6, 2023
@umbynos umbynos mentioned this pull request Aug 23, 2023
Closed
3 tasks
This was referenced Feb 8, 2024
Closed
Merged
@cmaglie
Copy link
Member

cmaglie commented Feb 12, 2024

Superseded by #900

@cmaglie cmaglie closed this Feb 12, 2024
@cmaglie cmaglie deleted the pluggable branch February 12, 2024 14:00
@per1234 per1234 added the conclusion: duplicate Has already been submitted label Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
conclusion: duplicate Has already been submitted topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@umbynos @cmaglie @per1234 @facchinm