Skip to content

Add CI workflow to run integration tests and to test Go code #659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 2, 2021

Conversation

umbynos
Copy link
Contributor

@umbynos umbynos commented Sep 1, 2021

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • Tests for the changes have been added (for bug fixes / features)
  • What kind of change does this PR introduce?

CI change

  • What is the current behavior?

The CI workflow that runs the test is old, outdated, and it's difficult to maintain

  • What is the new behavior?

On every push and pull request that affects relevant files, run the project's Go code tests andintegration tests.

  • Does this PR introduce a breaking change?

no

  • Other information:

On every push and pull request that affects relevant files, run the project's Go code tests.
On every push and pull request that affects relevant files, run the integration tests.
…`test-go-task` and `test-go-integration-task` workflows
@umbynos umbynos requested a review from a team September 1, 2021 09:46
@umbynos umbynos self-assigned this Sep 1, 2021
@umbynos umbynos changed the title Umbynos/enhance workflows Add CI workflow to run integration tests and to test Go code Sep 1, 2021
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@250b17c). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##             main    #659   +/-   ##
======================================
  Coverage        ?   8.46%           
======================================
  Files           ?      65           
  Lines           ?    5046           
  Branches        ?       0           
======================================
  Hits            ?     427           
  Misses          ?    4565           
  Partials        ?      54           
Flag Coverage Δ
unit 8.46% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 250b17c...32bd86e. Read the comment docs.

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Umberto!

@umbynos umbynos merged commit 714ffce into main Sep 2, 2021
@umbynos umbynos deleted the umbynos/enhance_workflows branch September 2, 2021 08:31
@umbynos umbynos mentioned this pull request Sep 15, 2021
2 tasks
@per1234 per1234 added topic: infrastructure Related to project infrastructure and removed github_actions labels Sep 24, 2021
umbynos added a commit that referenced this pull request Dec 13, 2021
… Go code (#659)

* Add CI workflow to test Go code

On every push and pull request that affects relevant files, run the project's Go code tests.

* rename test dir to tests (for uniformity with other tooling team repos)

* Add CI workflow to run integration tests

On every push and pull request that affects relevant files, run the integration tests.

* add again step to install dependencies (used by systray)

* disable actions/checkout action conversion of LF line endings to CRLF when checking out on a Windows runner.

* remove testing from the release workflow, since it's already done in `test-go-task` and `test-go-integration-task` workflows

* update release CI to use the new `task go:build`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants