Enhance e2e testing, add tests #622
Closed
+236
−77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umbynos
commented
Feb 25, 2021
| @@ -158,6 +160,7 @@ jobs: | |||
| name: arduino-create-agent-${{ matrix.os }}${{ matrix.arch }} | |||
| path: | | |||
| arduino-create-agent* | |||
| !arduino-create-agent_cli* | |||
There was a problem hiding this comment.
This is a breaking change. We do not ship in future releases the _cli binary. It will be used only to run the e2e tests
…rsion) TODO add significant test and try to obtain message exchanges
|
|
per1234
added
topic: infrastructure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
Tests
E2E tests are currently run by the CI only on MacOS (because it's the only OS with GUI support on GitHub runners).
With this PR I intend to use the
cliversion of the agent to run tests on all the platforms and not only on MacOSI'm adding also new tests
yes,
cliversion will not be shipped anymore by default with Linux (it's too problematic to handle, it auto-updates to the non-cli version and nobody is using it)