Refactor ota package #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polldo
force-pushed
the
polldo/ota-refactor
branch
from
d60d2e6 to
f2079e4
Compare
rsora
reviewed
Aug 5, 2022
polldo
force-pushed
the
polldo/ota-refactor
branch
from
e683fba to
f36992b
Compare
polldo
added a commit
that referenced
this pull request
Sep 2, 2022
Return a specific 'Econder' struct instead of a 'WriteCloser' interface. The 'Encoder' wraps a 'io.Writer' that's where the encoded file will be written to. In this way the consumer can decide when and how to open/close the writer. Add tests.
polldo
added a commit
that referenced
this pull request
Sep 2, 2022
Return a specific 'Econder' struct instead of a 'WriteCloser' interface. The 'Encoder' wraps a 'io.Writer' that's where the encoded file will be written to. In this way the consumer can decide when and how to open/close the writer. Add tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The ota package used to return a WriteCloser interface VERY weird:
interfaces should be used in the opposite way: return concrete types, takes interfaces as input. So, the consumer can then decide to close the io.Writer he decides to use (if needed).
Change description
Instead of returning a
WriteCloserinterface, it now returns a specificEncoder. This Encoder wraps a io.Writer that's where the encoded file will be written to.Add tests
Additional Notes
Tested with commands
ota uploadandota mass-uploadReviewer checklist
main.CONTRIBUTING.md) and are well formatted.