Defer file close

Author: polldo

command/ota/generate.go

@@ -55,6 +55,7 @@ func Generate(binFile string, outFile string, fqbn string) error {
 	if err != nil {
 		return err
 	}
+	defer out.Close()
 
 	enc := inota.NewEncoder(out, arduinoVendorID, productID)
 	err = enc.Encode(data)

command/ota/massupload.go

@@ -171,6 +171,7 @@ func run(uploader otaUploader, ids []string, otaFile string, expiration int) []R
 			results = append(results, r)
 			continue
 		}
+		defer file.Close()
 		jobs <- job{id: id, file: file}
 	}
 	close(jobs)

command/ota/upload.go

@@ -71,6 +71,7 @@ func Upload(params *UploadParams, cred *config.Credentials) error {
 	if err != nil {
 		return fmt.Errorf("%s: %w", "cannot open ota file", err)
 	}
+	defer file.Close()
 
 	expiration := otaExpirationMins
 	if params.Deferred {