Skip to content

Add device delete #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 5, 2021
Merged

Add device delete #22

merged 2 commits into from
Aug 5, 2021

Conversation

polldo
Copy link
Contributor

@polldo polldo commented Aug 5, 2021

Motivation

This PR introduces the command to delete a device from arduino iot cloud
Thus, now devices can be created, deleted and listed

Change description

To delete a device, a device id should be specified
$ iot-cloud-cli device delete -i <DEVICE_ID>

Additional Notes

- delete could take the device id as an argument instead of using a --id flag
edit: according to https://clig.dev/#arguments-and-flags use of flags is suggested over arguments

Reviewer checklist

  • PR address a single concern.
  • PR title and description are properly filled.
  • Changes will be merged in main.
  • Changes are covered by tests.
  • Logging is meaningful in case of troubleshooting.
  • History is clean, commit messages are meaningful (see CONTRIBUTING.md) and are well formatted.

@polldo polldo merged commit ee88678 into main Aug 5, 2021
@polldo polldo deleted the polldo/device-delete branch August 5, 2021 17:11
@polldo polldo mentioned this pull request Aug 5, 2021
6 tasks
polldo added a commit that referenced this pull request Sep 2, 2022
This PR introduces the command to delete a device from arduino iot cloud
Thus, now devices can be created, deleted and listed
To delete a device, a device id should be specified
$ iot-cloud-cli device delete -i <DEVICE_ID>

* Add device delete command

* Update readme
polldo added a commit that referenced this pull request Sep 2, 2022
This PR introduces the command to delete a device from arduino iot cloud
Thus, now devices can be created, deleted and listed
To delete a device, a device id should be specified
$ iot-cloud-cli device delete -i <DEVICE_ID>

* Add device delete command

* Update readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant