Skip to content

Add device list command #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Add device list command #19

wants to merge 5 commits into from

Conversation

polldo
Copy link
Contributor

@polldo polldo commented Aug 5, 2021

Motivation

This PR introduces the device commands to delete and retrieve devices
Thus, now devices can be created, deleted and listed

Change description

To list devices, no flags or arguments are needed, the command is simply
$ iot-cloud-cli device list

To delete a device, a device id should be specified
$ iot-cloud-cli device delete -i <DEVICE_ID>

maybe worth doing in the future:

  • list command could accept a list of IDs that should be retrieved from the cloud
    edit: a new show command might be better
    - delete could take the device id as an argument instead of using a --id flag
    edit: according to https://clig.dev/#arguments-and-flags flags are suggested over arguments

Additional Notes

Reviewer checklist

  • PR address a single concern.
  • PR title and description are properly filled.
  • Changes will be merged in main.
  • Changes are covered by tests.
  • Logging is meaningful in case of troubleshooting.
  • History is clean, commit messages are meaningful (see CONTRIBUTING.md) and are well formatted.

@polldo polldo requested a review from zmoog August 5, 2021 14:56
Copy link
Contributor

@zmoog zmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@polldo polldo changed the title Add remaining device commands Add device list command Aug 5, 2021
@polldo polldo force-pushed the polldo/device-crud-f branch from ac6f743 to 9af1690 Compare August 5, 2021 17:03
@polldo
Copy link
Contributor Author

polldo commented Aug 5, 2021

split and merged in #22 and #21

@polldo polldo closed this Aug 5, 2021
@polldo polldo deleted the polldo/device-crud-f branch September 2, 2022 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants