Remove ill dependency

[polldo]

Motivation

With go1.19 the cloud-cli doesn't work:

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0xbf97e6]

goroutine 1 [running]:
debug/elf.(*Section).ReadAt(0xc000336000?, {0xc0000f4240?, 0x270?, 0x24?}, 0x40?)
        <autogenerated>:1 +0x26
archive/zip.readDirectoryEnd({0xfb18c0, 0xc0000cb280}, 0x210)
        /usr/local/go/src/archive/zip/reader.go:526 +0xf5
archive/zip.(*Reader).init(0xc00028dd50, {0xfb18c0?, 0xc0000cb280}, 0x210)
        /usr/local/go/src/archive/zip/reader.go:97 +0x5c
archive/zip.NewReader({0xfb18c0, 0xc0000cb280}, 0x210)
        /usr/local/go/src/archive/zip/reader.go:90 +0x5e
github.com/daaku/go%2ezipexe.zipExeReaderElf({0xfb4c00?, 0xc000014b00}, 0x18fd49a)
        /home/poldo/go/pkg/mod/github.com/daaku/[email protected]/zipexe.go:128 +0x8b
github.com/daaku/go%2ezipexe.NewReader({0xfb4c00, 0xc000014b00}, 0x0?)
        /home/poldo/go/pkg/mod/github.com/daaku/[email protected]/zipexe.go:48 +0x98
github.com/daaku/go%2ezipexe.OpenCloser({0xc000042a80?, 0xc0000d35f0?})
        /home/poldo/go/pkg/mod/github.com/daaku/[email protected]/zipexe.go:30 +0x57
github.com/cmaglie/go%2erice.init.0()
        /home/poldo/go/pkg/mod/github.com/cmaglie/[email protected]/appended.go:42 +0x65

You can find more info about this issue at: golang/go#54227

Apparently we have an indirect dependency (github.com/cmaglie/go.rice) that relies on some other broken dependency.

$ go mod why github.com/cmaglie/go.rice

# github.com/cmaglie/go.rice
github.com/arduino/arduino-cloud-cli/internal/binary
github.com/arduino/arduino-fwuploader/indexes/download
github.com/cmaglie/go.rice

How it can be seen, the only direct dependency is from github.com/arduino/arduino-fwuploader, and it's just one function.

Change description

For an easy fix, I've just extracted the needed function from arduino-fwuploader removing the dependency.

Additional Notes

Reviewer checklist

• PR address a single concern.
• PR title and description are properly filled.
• Changes will be merged in main.
• Changes are covered by tests.
• Logging is meaningful in case of troubleshooting.
• History is clean, commit messages are meaningful (see CONTRIBUTING.md) and are well formatted.

[rsora]

Left a tiny cosmetic comment.

The rest is excellent and approved for merge 👍