Skip to content

Compile extract all artifacts #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
May 15, 2020
Merged

Compile extract all artifacts #687

merged 10 commits into from
May 15, 2020

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented May 6, 2020 •
edited by ubidefeo
Loading

Please check if the PR fulfills these requirements

  • The PR has no duplicates
  • The PR follows our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?
This PR implements the suggestion from @rsora -> #675 (comment)
In short:

  • the build artifacts are now saved in the sketch/build/<FQBN>/... directory without any rename
  • all sketch.ino.* files are copied (including .map, .lst, .elf, .zip etc.)

Example:

$ pwd
/home/cmaglie/Arduino/Blink

$ ls
Blink.ino

$ arduino-cli compile -b arduino:avr:uno
Sketch uses 968 bytes (3%) of program storage space. Maximum is 32256 bytes.
Global variables use 11 bytes (0%) of dynamic memory, leaving 2037 bytes for local variables. Maximum is 2048 bytes.

$ ls
Blink.ino  build

$ ls build/
arduino.avr.uno

$ ls build/arduino.avr.uno/
Blink.ino.eep  Blink.ino.elf  Blink.ino.hex  Blink.ino.with_bootloader.hex

$ arduino-cli compile -b arduino:samd:mkr1000
Sketch uses 11204 bytes (4%) of program storage space. Maximum is 262144 bytes.
Global variables use 2368 bytes of dynamic memory.

$ ls build/
arduino.avr.uno  arduino.samd.mkr1000

$ ls build/arduino.samd.mkr1000/
Blink.ino.bin  Blink.ino.elf  Blink.ino.hex  Blink.ino.map  Blink.ino.with_bootloader.hex

$ arduino-cli compile -b arduino:samd:mkr1000 --output-dir anotherdir
Sketch uses 11204 bytes (4%) of program storage space. Maximum is 262144 bytes.
Global variables use 2368 bytes of dynamic memory.

$ ls anotherdir/
Blink.ino.bin  Blink.ino.elf  Blink.ino.hex  Blink.ino.map  Blink.ino.with_bootloader.hex

Does this PR introduce a breaking change?
The options compile --output/-o and upload --input/-i have been removed and replaced by compile --output-dir and upload --input-dir respectively.

Closes #675
Closes #655

@rsora rsora requested review from per1234 and ubidefeo May 6, 2020 15:23
@cmaglie cmaglie force-pushed the compile_extract_all_artifacts branch 3 times, most recently from f9704d4 to 252acf9 Compare May 7, 2020 20:57
@per1234 per1234 mentioned this pull request May 8, 2020
Open
@cmaglie cmaglie marked this pull request as ready for review May 8, 2020 18:42
@cmaglie cmaglie requested review from rsora and masci May 8, 2020 18:42
@cmaglie cmaglie self-assigned this May 8, 2020
@cmaglie cmaglie added this to the 0.11.0 milestone May 8, 2020
per1234
per1234 approved these changes May 11, 2020
View reviewed changes
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks cmaglie! I tried it out with an assortment of platforms and had no problems uploading.

@ubidefeo
Copy link

tested a bunch of boards with ESP32, ESP8266, SAMD21, ATMega32u4, ATMega328, they all worked and uploaded correctly

@rsora
Copy link
Contributor

rsora commented May 12, 2020 •
edited
Loading

This PR should solve also #641 and #476

ubidefeo
ubidefeo approved these changes May 12, 2020
View reviewed changes
Copy link

@ubidefeo ubidefeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't give feedback on code changes but the feature works and makes everything much more cleaner

@rsora
Copy link
Contributor

rsora commented May 12, 2020

This PR should also solve #673

rsora
rsora approved these changes May 12, 2020
View reviewed changes
Copy link
Contributor

@rsora rsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! LGTM!
I have tested how this changes affects the debug feature and it's all 👍 (wih a MKRZero)

@cmaglie cmaglie mentioned this pull request May 15, 2020
Merged
2 tasks
@cmaglie cmaglie mentioned this pull request May 15, 2020
Merged
4 tasks
@cmaglie cmaglie force-pushed the compile_extract_all_artifacts branch from cfe70ff to 31bf766 Compare May 15, 2020 15:30
@cmaglie cmaglie merged commit ebc28e1 into arduino:master May 15, 2020
@cmaglie cmaglie deleted the compile_extract_all_artifacts branch May 15, 2020 15:50
@cmaglie cmaglie mentioned this pull request May 26, 2020
Closed
@rsora rsora mentioned this pull request Jun 26, 2020
Closed
fpistm added a commit to fpistm/Arduino_Core_STM32 that referenced this pull request Jun 29, 2020
@fpistm
[CI] Update binary management after cli change.
6575b45 
With new arduino-cli v0.11.0, output management has changed.
See arduino/arduino-cli#687

Binaries are always copied.

Signed-off-by: Frederic Pillon <[email protected]>
@fpistm fpistm mentioned this pull request Jun 29, 2020
Merged
fpistm added a commit to fpistm/Arduino_Core_STM32 that referenced this pull request Jun 29, 2020
@fpistm
[CI] Update binary management after cli change.
1f81530 
With new arduino-cli v0.11.0, output management has changed.
See arduino/arduino-cli#687

Binaries are always copied.

Signed-off-by: Frederic Pillon <[email protected]>
fpistm added a commit to fpistm/Arduino_Core_STM32 that referenced this pull request Jun 30, 2020
@fpistm
[CI] Update binary management after cli change.
2c361ef 
With new arduino-cli v0.11.0, output management has changed.
See arduino/arduino-cli#687

Binaries are always copied.

Signed-off-by: Frederic Pillon <[email protected]>
fpistm added a commit to fpistm/Arduino_Core_STM32 that referenced this pull request Jul 2, 2020
@fpistm
[CI] Update binary management after cli change.
7568025 
With new arduino-cli v0.11.0, output management has changed.
See arduino/arduino-cli#687

Binaries are always copied.

Signed-off-by: Frederic Pillon <[email protected]>
@per1234 per1234 mentioned this pull request Jul 12, 2020
Closed
@draco2003 draco2003 mentioned this pull request Jan 29, 2021
Closed
@per1234 per1234 added the topic: code Related to content of the project itself label Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ubidefeo ubidefeo ubidefeo approved these changes

@per1234 per1234 per1234 approved these changes

@rsora rsora rsora approved these changes

@masci masci Awaiting requested review from masci

Assignees

@cmaglie cmaglie

Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.
4 participants
@cmaglie @ubidefeo @rsora @per1234