-
-
Notifications
You must be signed in to change notification settings - Fork 398
Allow upload using binaries from build-path #675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After going through your code and a bit of discussion with @cmaglie here my considerations: TL;DR: with #655 nad this PR, we are basically trying to solve a "Core configuration" problem, rather than a CLI problem This is our context:
So, it seems that we have the following strategies to solve this issue in the CLI:
Actually I believe that 4 could be the best strategy because:
@cmaglie WDYT? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
New flags are added to the
upload
command:With
-n, --upload-from-build-path
the CLI will upload binaries from the build path.--build-path
force a custom build-path instead of the build-path autogenerated by the CLI.The new behaviour is now the default if chained compile + upload (
compile -u
) is used.Currently:
arduino-cli compile -u ...
will produce the binaries in the sketch folder will use them for the upload.arduino-cli compile -n -u ...
will not work (because the-n/--dry-run
will not copy binaries in the sketch folder and consequently the upload will fail.After the patch
arduino-cli compile -u ...
will produce the binaries in the sketch folder but for the upload the binaries in the build path will be used for the upload. This should fix Upload build path is different than output build path #641 at least for the chained build+upload.arduino-cli compile -n -u ...
will now work, it will upload without creating the binaries in the sketch folder (because the-n/--dry-run
will not copy binaries in the sketch folder but the upload will use the binaries from the build-path 👍 ).It should not.