Add smart artifact find during upload #655
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
(Originates from a fix for #641)
The CLI
upload
step searches also in fallback locations for artifacts to upload, in case these files are missing.The CLI
upload
step assumes that the artifacts generated by the compile phase are also "exported" into the sketch folder (see the Java IDE export feature). This means that during thecompile
phase, the output files generated by the specific platform compiler are placed:builder.GenBuildPath(sketchPath)
or
--build-path
pathAnd then "exported" (copied) into the sketch path.
This behavior could create issues for cores that do not implement correctly the "export" variables in the
platform.txt
, see for example this core in which you have the export recipe file extension.hex
that is misaligned with the upload file extension.zip
Since the export feature is not fundamental in the Java IDE, 3rd party core maintainers are not forced to implement it or to implement it 100% correctly, so the CLI must take in account this aspect
The upload command search process is the following:
importFile
--build-path
(if passed during acompile --upload
command)builder.GenBuildPath(sketchPath)
)Not really, this change adds fallback strategies to the
upload
implementation that should be transparent for the user.I assumed in this PR that artifact files in fallback paths are always in this form
sketch.Name+".ino"+ext
and not in the exported formsketch.Name + "." + fqbnSuffix + ext
See how to contribute