Fix "lib uninstall" when library name contains spaces

[howjmay]

Now, the "_" is replaced with a blanket " ", to reslove the
inconsistency problem. However, use the name of the installing
library may be a better solution.

fixes #362

BTW, when we uninstall libraries, there are no messages to notify the user libraries are successfully uninstalled.
However, when we install libraries message like Installed LiquidCrystal [email protected] is printed to notify libraries are successfully installed.

[masci]

Thanks for the PR!
Before we start reviewing, can you fix these two tests that are failing?
https://github.com/arduino/arduino-cli/blob/master/legacy/builder/test/libraries_loader_test.go#L92
https://github.com/arduino/arduino-cli/blob/master/legacy/builder/test/libraries_loader_test.go#L200

[masci]

@howjmay we're almost there, now integration tests are failing here: https://github.com/arduino/arduino-cli/blob/master/test/test_lib.py#L61
You can find the nstructions to run integration tests locally here: https://github.com/arduino/arduino-cli/tree/master/test let me know if you need any guidance, those tests require a Python3 interpreter to run.

[howjmay]

Thanks @masci
It seems I may meet a problem, but I am still digging it.
I will ask for help if I can't solve alone!

[howjmay]

Hi @masci Sorry for answering late. My PC was broken in the last few weeks.
I met a problem that in

arduino-cli/arduino/utils/filenames.go

Line 22 in 292277f

func SanitizeName(origName string) string {

Name with space " " would be replace with underline "_", but this would cause a problem if I simply transform an underline back to space. Because the underline may be transformed from other symbol.

I am kind confused that how can I solve this problem. Maybe we need a naming rule for libraries ?

[zmoog]

Hi @howjmay, unfortunately, we currently don't have a specification for the library names.

The original library name is changed here

arduino-cli/arduino/libraries/librariesmanager/install.go

Line 40 in bc6c823

saneName := utils.SanitizeName(indexLibrary.Library.Name)

using the SanitizeName() function to be more filesystem friendly and is also used internally as an identifier for the library within the LibrariesManager data structures.

Why don't we limit the use of the sanitized version of the library name inside the librariesmanager package only?

We could change this:

arduino-cli/arduino/libraries/librariesmanager/librariesmanager.go

Line 212 in bc6c823

alternatives, have := sc.Libraries[libRef.Name]

into something like this:

    saneName := utils.SanitizeName(libRef.Name)
    alternatives, have := sc.Libraries[saneName]

All the sanitize/normalization stuff would remain inside the librariesmanager package making it easier to change it into something else later on.

[howjmay]

@zmoog Thank you !!
I didn't be aware there is a way like this!!

[howjmay]

Hi @masci I failed in CI for some unknown issue. Do you know what happen?

[masci]

@howjmay my apologies, the CI system is currently disabled due to administrative problems but it'll be back online soon. For the time being I'm afraid you have to rely on running the tests locally, thanks for your patience!

[howjmay]

Hi @masci How is the situation of CI?
Last time I ran the test of this PR, I passed it, even though I met some problems to run tests again.

[masci]

@howjmay CI is back, you can add a commit and push (or just force-push last commit) to retrigger

[howjmay]

done

[masci]

LGTM, I wrote an integration test for this feature, I'll push it in a separate PR.
Thanks for your code!

[howjmay]

Thank you @masci