Skip to content

Commit cdcd726

Browse files
committed
Libraries (un)installation name inconcistency
Now, the "_" is replaced with a blanket " ", to reslove the inconsistency problem. However, use the name of the installing library may be a better solution.
1 parent 1ceab8b commit cdcd726

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

Diff for: arduino/libraries/loader.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ func makeNewLibrary(libraryDir *paths.Path, location LibraryLocation) (*Library,
9696
library.Version = v
9797
}
9898

99-
library.Name = libraryDir.Base()
99+
library.Name = strings.ReplaceAll(libraryDir.Base(), "_", " ")
100100
library.RealName = strings.TrimSpace(libProperties.Get("name"))
101101
library.Author = strings.TrimSpace(libProperties.Get("author"))
102102
library.Maintainer = strings.TrimSpace(libProperties.Get("maintainer"))

Diff for: legacy/builder/test/libraries_loader_test.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ func TestLoadLibrariesAVR(t *testing.T) {
8989
require.Equal(t, "ANewLibrary-master", libs[idx].Name)
9090

9191
idx++
92-
require.Equal(t, "Adafruit_PN532", libs[idx].Name)
92+
require.Equal(t, "Adafruit PN532", libs[idx].Name)
9393
require.True(t, Abs(t, paths.New("downloaded_libraries/Adafruit_PN532")).EquivalentTo(libs[idx].InstallDir))
9494
require.True(t, Abs(t, paths.New("downloaded_libraries/Adafruit_PN532")).EquivalentTo(libs[idx].SourceDir))
9595
require.Equal(t, 1, len(libs[idx].Architectures))
@@ -197,7 +197,7 @@ func TestLoadLibrariesSAM(t *testing.T) {
197197
idx := 0
198198
require.Equal(t, "ANewLibrary-master", libraries[idx].Name)
199199
idx++
200-
require.Equal(t, "Adafruit_PN532", libraries[idx].Name)
200+
require.Equal(t, "Adafruit PN532", libraries[idx].Name)
201201
idx++
202202
require.Equal(t, "Audio", libraries[idx].Name)
203203
idx++

0 commit comments

Comments
 (0)