-
-
Notifications
You must be signed in to change notification settings - Fork 398
Add diagnostics in the preprocessor #2515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
alessio-perugini
merged 9 commits into
master
from
2511-add-diagnostics-in-the-preprocessor
Feb 19, 2024
Merged
Add diagnostics in the preprocessor #2515
alessio-perugini
merged 9 commits into
master
from
2511-add-diagnostics-in-the-preprocessor
Feb 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2515 +/- ##
==========================================
+ Coverage 68.92% 69.74% +0.82%
==========================================
Files 204 206 +2
Lines 20452 20845 +393
==========================================
+ Hits 14096 14538 +442
+ Misses 5207 5166 -41
+ Partials 1149 1141 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
0498c1a
to
ff36bba
Compare
The `diagnostics` field was duplicated, it should be retrived by calling only .builer_result.diagnostics
0d6989e
to
22905b6
Compare
22905b6
to
06ee3bd
Compare
umbynos
approved these changes
Feb 2, 2024
cmaglie
reviewed
Feb 2, 2024
internal/arduino/builder/internal/preprocessor/arduino_preprocessor.go
Outdated
Show resolved
Hide resolved
9be2db0
to
e756cf3
Compare
e756cf3
to
be0b8c4
Compare
cmaglie
approved these changes
Feb 19, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
topic: code
Related to content of the project itself
type: imperfection
Perceived defect in any part of project
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.md
has been updated with a migration guide (for breaking changes)configuration.schema.json
updated if new parameters are added.What kind of change does this PR introduce?
We're adding the diagnostics in the preprocessing part.
What is the current behavior?
Currently, the diagnostics are considered only for the sketch compilation.
What is the new behavior?
The diagnostics field will report errors from the preprocessor and the compiler.
Does this PR introduce a breaking change, and is titled accordingly?
Other information
I'm proposing to use a struct that Stores the information of the diagnostics instead of using a callback approach. We can always revert that.