Skip to content

Output window should report a successful upload #1290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
3 tasks done
InstantMuffin opened this issue Aug 4, 2022 · 5 comments
Open
3 tasks done

Output window should report a successful upload #1290

InstantMuffin opened this issue Aug 4, 2022 · 5 comments
Assignees
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement

Comments

@InstantMuffin
Copy link
Contributor

InstantMuffin commented Aug 4, 2022

Describe the request

I would love if the output window would give a success message whenever an upload finished successfully.

Describe the current behavior

Currently whenever an upload is successful the output window shows no entry of this.
It leads the user believe that an upload may not have happened (if the user doesn't see the popups) or the user trying to debug an issue scrolling up the logs does not find a notification that an upload happened at all.
All I myself see and guess is that compiling the sketch was successful. I was quite bothered trying to track down uploading issues with the message not happening (and the popups being delayed and old ones staying on for a long time due to a different reported bug). Uploading being unsuccessful could be because simply no board was selected or because of some other issues that for some reason don't trigger an upload.

Instead in case if the upload fails the user currently does get a detailed message.

Arduino IDE version

2.0.0-rc9.1 and nightly

Operating system

Linux

Operating system version

XUbuntu 22.04 LTS

Additional context

Additional requests

Issue checklist

  • I searched for previous requests in the issue tracker
  • I verified the feature was still missing when using the latest nightly build
  • My request contains all necessary details
@InstantMuffin InstantMuffin added the type: enhancement Proposed improvement label Aug 4, 2022
@per1234
Copy link
Contributor

per1234 commented Aug 4, 2022

Thanks for your suggestion @InstantMuffin. I'll provide some supplemental information:

Prior to 4611381, messages were printed to the Output view at the successful completion of compilations:

--------------------------
Compilation complete.

and completion of uploads:

--------------------------
Compilation complete.
--------------------------
upload complete.

Those were removed by #1064.

I assumed that was done intentionally, with the idea they were superfluous to the notifications, but @kittaakos might be able to provide better insight into the reason for the change.

@InstantMuffin
Copy link
Contributor Author

Yes, that was what I forgot to mention. I do distinctively remember at least the old IDE to have a specific feedback response.
Thank you.

@per1234 per1234 added the topic: code Related to content of the project itself label Aug 4, 2022
@kittaakos
Copy link
Contributor

I assumed that was done intentionally, with the idea they were superfluous to the notifications, but @kittaakos might be able to provide better insight into the reason for the change.

IDE2 wants to show what's coming from the CLI, nothing more, nothing less. We might like to introduce an optional flag in the CLI to print out the task stages, such as verify, upload, etc.

Also, for #1275 and #1064 IDE2 uses the output from the CLI as-is to parse the error locations. It's already been problematic to parse the output 😕

Furthermore, the Java IDE does not print such additional info to the output either, even with verbose verify and upload options:

/Users/a.kitta/Library/Arduino15/packages/arduino/tools/arm-none-eabi-gcc/7-2017q4/bin/arm-none-eabi-size -A /var/folders/z1/xkw1yh5n7rz4n8djprp1mdn80000gn/T/arduino_build_503695/sketch_2.ino.elf
Sketch uses 89236 bytes (0%) of program storage space. Maximum is 16777216 bytes.
Global variables use 43448 bytes (16%) of dynamic memory, leaving 226888 bytes for local variables. Maximum is 270336 bytes.
Forcing reset using 1200bps open/close on port /dev/cu.usbmodem14401
/Users/a.kitta/Library/Arduino15/packages/arduino/tools/rp2040tools/1.0.6/rp2040load -v -D /var/folders/z1/xkw1yh5n7rz4n8djprp1mdn80000gn/T/arduino_build_503695/sketch_2.ino.elf 
rp2040load 1.0.6 - compiled with go1.16.2
Loading into Flash: [==============================]  100%

I am not saying this issue won't fix, but maybe we should figure out another way to indicate the success and failure statuses at a different place than the output.

@Fluxanode

This comment has been minimized.

@dankeboy36
Copy link
Contributor

Also, for #1275 and #1064 IDE2 uses the output from the CLI as-is to parse the error locations. It's already been problematic to parse the output 😕

The Arduino CLI provides APIs to retrieve the compiler errors in machine-readable format: arduino/arduino-cli#2182 and arduino/arduino-cli#2515. Printing additional strings to the output should not be a technical obstacle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

No branches or pull requests

6 participants