feat: library folder name priority promotion for -main suffix
#2233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
RodrigoDornelles
changed the title
-main suffix #2226-main suffix
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2233 +/- ##
==========================================
- Coverage 63.02% 62.97% -0.06%
==========================================
Files 220 220
Lines 19499 19501 +2
==========================================
- Hits 12290 12280 -10
- Misses 6128 6137 +9
- Partials 1081 1084 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
per1234
added
type: enhancement
For updating the tests, just add the missing case |
Co-authored-by: Cristian Maglie <[email protected]>
fix: TestClosestMatchWithTotallyDifferentNames in cpp_test.go
3 tasks
cmaglie
approved these changes
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
adds support for libraries downloaded from git repositories as zip where the branch name is
mainWhat is the current behavior?
only master branch prioritized.
related in #2226
What is the new behavior?
in addition to the
mainbranch being considered it has higher priority thanmaster.Other information
I didn't quite understand how to implement the tests, with a little help I can finish this part.
I added weight +10 in relation to master based on optmized architecture above wildcard, if you have a recommendation for another amount I will make this adjustment.