Add library folder name priority promotion for -main
suffix
#2226
Labels
conclusion: resolved
Issue was resolved
topic: build-process
Related to the sketch build process
topic: code
Related to content of the project itself
type: enhancement
Proposed improvement
Describe the request
The library dependency resolution process currently promotes the library folder name priority for the
-master
suffix:https://arduino.github.io/arduino-cli/latest/sketch-build-process/#folder-name-priority
arduino-cli/arduino/libraries/librariesresolver/cpp.go
Line 195 in eca9d9a
The reason for this is that when you use GitHub's "Download ZIP", the ref is appended to the folder name (e.g. if the repository name is "FooLib" and the user is downloading from the tip of the repository's
master
branch, the resulting folder name of the unzipped library will beFooLib-master
).The reason for this special treatment of
-master
is because in years pastmaster
was the default branch name of Git and GitHub repositories.However, the default default branch name has since been changed to
main
:init.defaultBranch
git-for-windows/build-extra#307 (comment)The folder name priority should be promoted for libraries with the
-main
suffix just the same as is already done for the-master
suffix.Describe the current behavior
Library folder name priority is promoted for the
-master
suffix but not the-main
suffix.Arduino CLI version
eca9d9a
Operating system
All
Operating system version
Any
Issue checklist
The text was updated successfully, but these errors were encountered: