-
-
Notifications
You must be signed in to change notification settings - Fork 398
feat: library folder name priority promotion for -main
suffix
#2233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
-main
suffix #2226-main
suffix
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2233 +/- ##
==========================================
- Coverage 63.02% 62.97% -0.06%
==========================================
Files 220 220
Lines 19499 19501 +2
==========================================
- Hits 12290 12280 -10
- Misses 6128 6137 +9
- Partials 1081 1084 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For updating the tests, just add the missing case |
Co-authored-by: Cristian Maglie <[email protected]>
fix: TestClosestMatchWithTotallyDifferentNames in cpp_test.go
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.md
has been updated with a migration guide (for breaking changes)configuration.schema.json
updated if new parameters are added.What kind of change does this PR introduce?
adds support for libraries downloaded from git repositories as zip where the branch name is
main
What is the current behavior?
only master branch prioritized.
related in #2226
What is the new behavior?
in addition to the
main
branch being considered it has higher priority thanmaster
.Other information
I didn't quite understand how to implement the tests, with a little help I can finish this part.
I added weight +10 in relation to master based on optmized architecture above wildcard, if you have a recommendation for another amount I will make this adjustment.