Skip to content

Fixed integration test #2185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 24, 2023
Merged

Fixed integration test #2185

merged 2 commits into from
May 24, 2023

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented May 24, 2023

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Fix an integration test.
The test checks a download URL for a dependency that has been updated.
Previously it downloaded version 3.3.1, but at the moment the new dependency is 3.4.0.
This fix makes the test independent from such changes.

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change, and is titled accordingly?

Other information

cmaglie added 2 commits May 24, 2023 14:44
The dependency has been updated, previously it was downloaded the version
3.3.1, but at the moment the new dependency is 3.4.0.
This fix makes the test independent from such changes.
@cmaglie cmaglie self-assigned this May 24, 2023
@cmaglie cmaglie added topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project labels May 24, 2023
@umbynos
Copy link
Contributor

umbynos commented May 24, 2023

remember to [skip-changelog]

Copy link
Contributor

@alessio-perugini alessio-perugini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
image

@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (62f5caf) 62.63% compared to head (97e7295) 62.63%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2185   +/-   ##
=======================================
  Coverage   62.63%   62.63%           
=======================================
  Files         223      223           
  Lines       19501    19501           
=======================================
  Hits        12214    12214           
  Misses       6201     6201           
  Partials     1086     1086           
Flag Coverage Δ
unit 62.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cmaglie cmaglie merged commit fbf3255 into arduino:master May 24, 2023
@cmaglie cmaglie deleted the fix_test branch May 24, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants