[skip-changelog] Fixed integration test (#2185)

* Use json output in test

* Fixed integration test

The dependency has been updated, previously it was downloaded the version
3.3.1, but at the moment the new dependency is 3.4.0.
This fix makes the test independent from such changes.

Author: cmaglie

Diff for: internal/integrationtest/lib/lib_test.go

@@ -1510,42 +1510,41 @@ func TestLibQueryParameters(t *testing.T) {
 	require.NoError(t, err)
 
 	// Check query=install when a library is installed
-	stdout, _, err := cli.Run("lib", "install", "[email protected]", "-v", "--log-level", "debug")
+	stdout, _, err := cli.Run("lib", "install", "[email protected]", "-v", "--log-level", "debug", "--log-format", "json")
 	require.NoError(t, err)
-	require.Contains(t, string(stdout),
-		"Starting download                             \x1b[36murl\x1b[0m=\"https://downloads.arduino.cc/libraries/github.com/arduino-libraries/USBHost-1.0.0.zip?query=install\"\n")
+	require.Contains(t, string(stdout), `"url":"https://downloads.arduino.cc/libraries/github.com/arduino-libraries/USBHost-1.0.0.zip?query=install"`)
 
 	// Check query=upgrade when a library is upgraded
-	stdout, _, err = cli.Run("lib", "upgrade", "USBHost", "-v", "--log-level", "debug")
+	stdout, _, err = cli.Run("lib", "upgrade", "USBHost", "-v", "--log-level", "debug", "--log-format", "json")
 	require.NoError(t, err)
-	require.Contains(t, string(stdout),
-		"Starting download                             \x1b[36murl\x1b[0m=\"https://downloads.arduino.cc/libraries/github.com/arduino-libraries/USBHost-1.0.5.zip?query=upgrade\"\n")
+	require.Contains(t, string(stdout), `"url":"https://downloads.arduino.cc/libraries/github.com/arduino-libraries/USBHost-1.0.5.zip?query=upgrade"`)
 
 	// Check query=depends when a library dependency is installed
-	stdout, _, err = cli.Run("lib", "install", "[email protected]", "-v", "--log-level", "debug")
+	stdout, _, err = cli.Run("lib", "deps", "[email protected]", "--format", "json")
 	require.NoError(t, err)
-	require.Contains(t, string(stdout),
-		"Starting download                             \x1b[36murl\x1b[0m=\"https://downloads.arduino.cc/libraries/github.com/MajicDesigns/MD_MAX72XX-3.3.1.zip?query=depends\"\n")
+	// determine the version installed as dependency
+	MDMAX72XXversion := strings.Trim(requirejson.Parse(t, stdout).Query(`.dependencies[0].version_required`).String(), `"`)
+
+	stdout, _, err = cli.Run("lib", "install", "[email protected]", "-v", "--log-level", "debug", "--log-format", "json")
+	require.NoError(t, err)
+	require.Contains(t, string(stdout), `"url":"https://downloads.arduino.cc/libraries/github.com/MajicDesigns/MD_MAX72XX-`+MDMAX72XXversion+`.zip?query=depends"`)
 
 	// Check query=download when a library is downloaded
-	stdout, _, err = cli.Run("lib", "download", "[email protected]", "-v", "--log-level", "debug")
+	stdout, _, err = cli.Run("lib", "download", "[email protected]", "-v", "--log-level", "debug", "--log-format", "json")
 	require.NoError(t, err)
-	require.Contains(t, string(stdout),
-		"Starting download                             \x1b[36murl\x1b[0m=\"https://downloads.arduino.cc/libraries/github.com/arduino-libraries/WiFi101-0.16.1.zip?query=download\"\n")
+	require.Contains(t, string(stdout), `"url":"https://downloads.arduino.cc/libraries/github.com/arduino-libraries/WiFi101-0.16.1.zip?query=download"`)
 
 	// Check query=install-builtin when a library dependency is installed in builtin-directory
 	cliEnv := cli.GetDefaultEnv()
 	cliEnv["ARDUINO_DIRECTORIES_BUILTIN_LIBRARIES"] = cli.DataDir().Join("libraries").String()
-	stdout, _, err = cli.RunWithCustomEnv(cliEnv, "lib", "install", "[email protected]", "--install-in-builtin-dir", "-v", "--log-level", "debug")
+	stdout, _, err = cli.RunWithCustomEnv(cliEnv, "lib", "install", "[email protected]", "--install-in-builtin-dir", "-v", "--log-level", "debug", "--log-format", "json")
 	require.NoError(t, err)
-	require.Contains(t, string(stdout),
-		"Starting download                             \x1b[36murl\x1b[0m=\"https://downloads.arduino.cc/libraries/github.com/firmata/Firmata-2.5.3.zip?query=install-builtin\"\n")
+	require.Contains(t, string(stdout), `"url":"https://downloads.arduino.cc/libraries/github.com/firmata/Firmata-2.5.3.zip?query=install-builtin`)
 
 	// Check query=update-builtin when a library dependency is updated in builtin-directory
-	stdout, _, err = cli.RunWithCustomEnv(cliEnv, "lib", "install", "[email protected]", "--install-in-builtin-dir", "-v", "--log-level", "debug")
+	stdout, _, err = cli.RunWithCustomEnv(cliEnv, "lib", "install", "[email protected]", "--install-in-builtin-dir", "-v", "--log-level", "debug", "--log-format", "json")
 	require.NoError(t, err)
-	require.Contains(t, string(stdout),
-		"Starting download                             \x1b[36murl\x1b[0m=\"https://downloads.arduino.cc/libraries/github.com/firmata/Firmata-2.5.9.zip?query=upgrade-builtin\"\n")
+	require.Contains(t, string(stdout), `"url":"https://downloads.arduino.cc/libraries/github.com/firmata/Firmata-2.5.9.zip?query=upgrade-builtin"`)
 }
 
 func TestLibBundlesWhenLibWithTheSameNameIsInstalledGlobally(t *testing.T) {