Copy package to destination if move failed during resource installation

[RangerCD]

Please check if the PR fulfills these requirements

See how to contribute

• The PR has no duplicates (please search among the Pull Requests
  before creating one)
• The PR follows
  our contributing guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)
• UPGRADING.md has been updated with a migration guide (for breaking changes)

What kind of change does this PR introduce?

This PR improves compatibility with antivirus software.

What is the current behavior?

CLI reports

Installing Seeeduino:[email protected]...
Error during install: Cannot install tool Seeeduino:[email protected]: moving extracted archive to destination dir: rename C:\Users\XXX\AppData\Local\Arduino15\tmp\package-2842439214\ARM.CMSIS.5.7.0 c:\Users\XXX\AppData\Local\Arduino15\packages\Seeeduino\tools\CMSIS\5.7.0: Access is denied.

if an antivirus software is still scanning temp files when CLI trys to move them to destination dir. This is a common error if you are using an antivirus software, and there are lots of discussion.

All previous suggestion is to disable antivirus temporarily. It's not a good solution because:

• Disabling antivirus is risky, even just for a couple minutes to install a package, or you might forget to enable it again
• User might not allowed to disable antivirus, due to security policy, especially in a lab

Some related issues, all suggested to solve manually:

• Error during install of arduino:avr.  #636
• core install fails with "Access is denied" error #723
• Error: 13 INTERNAL: Cannot install tool... arduino-ide#1352
• https://forum.arduino.cc/t/failed-to-install-platform/967472

What is the new behavior?

CLI will try to copy temp files if move failed, no error will be reported even if antivirus is scanning temp files.

To demonstrate new behavior, I've added debug logs in my demo and the output looks like:

Installing Seeeduino:[email protected]...
+Failed to move dir
+Copy succeeded
Seeeduino:[email protected] installed

Does this PR introduce a breaking change, and is titled accordingly?

No

Other information

Copy takes a little bit more time than move, but it's only called if move failed. And it's definitely faster and safer than searching for error message, disabling antivirus, and rerun installation.

Temp files will not be left permanently, they will be removed by defer tempDir.RemoveAll() here.

[cmaglie]

Thank you for the patch and for the clear explanation, I never understood the reason for these random Access denied errors, now it's clear!