Fix integration test intermittent failure due to download/file in use #1905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required since the integration tests shares the download folder. Still not ideal, it would be better if the cli could handle concurrent access to the download folder (from multiple cli processes...), but at least allows to run the tests without random failures.
Codecov ReportBase: 36.74% // Head: 36.72% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1905 +/- ##
==========================================
- Coverage 36.74% 36.72% -0.02%
==========================================
Files 231 231
Lines 19724 19724
==========================================
- Hits 7247 7244 -3
- Misses 11646 11648 +2
- Partials 831 832 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
umbynos
approved these changes
Oct 4, 2022
per1234
added
topic: infrastructure
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)What kind of change does this PR introduce?
A workaround to fix the integration test.
What is the current behavior?
go-lang tests in each package are run in parallel (instead the tests inside each package are run sequentially). This is not good for tests in
integrationtestbecause these share the download directory to save bandwidth.What is the new behavior?
The tests are run sequentially using the
-p 1flagDoes this PR introduce a breaking change, and is titled accordingly?
No
Other information
Maybe a better long term solution could be to move all integration tests in the same "package" under
internal/intergationtest. @MatteoPologruto @umbynos