-
-
Notifications
You must be signed in to change notification settings - Fork 398
[skip-changelog] Migrate tests from test_board.py
to board_test.go
#1847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportBase: 36.65% // Head: 36.69% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1847 +/- ##
==========================================
+ Coverage 36.65% 36.69% +0.04%
==========================================
Files 231 231
Lines 19683 19699 +16
==========================================
+ Hits 7215 7229 +14
+ Misses 11640 11639 -1
- Partials 828 831 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
410eda2
to
a7a9f9b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO we can dramatically improve readability through the use of requirejson
let's have a chat about it.
673d236
to
4d0ddac
Compare
4d0ddac
to
962591f
Compare
ae1ee5c
to
c21f361
Compare
…d.py to board_test.go
…py to board_test.go
c21f361
to
448a41b
Compare
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.md
has been updated with a migration guide (for breaking changes)What kind of change does this PR introduce?
Infrastructure enhancement
What is the new behavior?
This PR is a followup to PR #1806
Integration tests that were previously present in
test_board.py
have been rewritten inboard_test.go
, without changing their original purpose.The tests are the following:
Does this PR introduce a breaking change, and is
titled accordingly?
No
See how to contribute