Skip to content

[skip changelog] Fix integration tests by setting a maximum python version #1470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2021

Conversation

silvanocerza
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?

Fixes an issue with Python integration tests.

  • What is the current behavior?

Integration tests are failing because a library has issue with Python 3.9.7.

Failing workflow: https://github.com/arduino/arduino-cli/runs/3698900893?check_suite_focus=true

  • What is the new behavior?

Constrain maximum Python version usable to be equal or greater than 3.8 and older than 3.9.7 to stop integration tests from failing.

Nope.

  • Other information:

Probably related to gitpython-developers/GitPython#1341.


See how to contribute

@silvanocerza silvanocerza requested a review from a team September 24, 2021 13:15
@silvanocerza silvanocerza self-assigned this Sep 24, 2021
@per1234
Copy link
Contributor

per1234 commented Sep 24, 2021

@silvanocerza I fixed this previously with #1442 but it wasn't cherry-picked into the 0.19.1-rc2 branch:
https://github.com/arduino/arduino-cli/blob/0.19.1-rc2/.github/workflows/test-go-integration-task.yml#L8

But I think this is still an important change to do to fix the issue for running the tests locally. I didn't consider that side of things.

@silvanocerza
Copy link
Contributor Author

Ah! I completely missed that PR, I was kinda confused why it was failing today but not yesterday. Now it makes sense, thanks Per.

@per1234 per1234 added topic: infrastructure Related to project infrastructure and removed topic: testing labels Sep 24, 2021
@silvanocerza silvanocerza merged commit b0df729 into master Sep 24, 2021
@silvanocerza silvanocerza deleted the scerza/fix-integration-tests branch September 24, 2021 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants