-
-
Notifications
You must be signed in to change notification settings - Fork 398
Pass of lint for .proto files #1223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new Arduino IDE cannot wait to use the new gRPC API 💄
7344ce6
to
298ea05
Compare
…warning There is one error remaining that require a more involved refactoring.
Seems alright to me, I'd add a task and related workflow to check formatting otherwise I fear we'll drift into badly formatted files again. |
I agree, and suggest doing the same with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one small change in UPGRADING.md
, the rest is good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! 🚀
I've used
buf
linter to perform linting of the .proto files.The linter warnings rules fixed by this PR are:
SERVICE_SUFFIX
RPC_RESPONSE_STANDARD_NAME
RPC_REQUEST_STANDARD_NAME
RPC_REQUEST_RESPONSE_UNIQUE
ENUM_VALUE_PREFIX
ENUM_VALUE_UPPER_SNAKE_CASE
FIELD_LOWER_SNAKE_CASE
PACKAGE_VERSION_SUFFIX
PACKAGE_DIRECTORY_MATCH
The changes above should not affect the behavior of the RPC API.
Anyway, those are breaking changes since they change the signature of the RPC API and the CLI JSON output in some cases.
The remaining linter warnings require a more in-depth analysis to be fixed: