Added lint and format as Taskfile targets

Author: cmaglie

Diff for: .github/workflows/test.yaml

@@ -22,7 +22,7 @@ jobs:
       - name: Install Go
         uses: actions/setup-go@v2
         with:
-          go-version: "1.14"
+          go-version: "1.16"
 
       - name: Install Go deps
         # Since 10/23/2019 pwsh is the default shell
@@ -50,16 +50,27 @@ jobs:
       - name: Install Poetry
         run: pip install poetry
 
+      - name: Install buf (protoc linter)
+        if: runner.os == 'Linux'
+        run: |
+          go install github.com/bufbuild/buf/cmd/buf@latest
+          go install github.com/bufbuild/buf/cmd/protoc-gen-buf-breaking@latest
+          go install github.com/bufbuild/buf/cmd/protoc-gen-buf-lint@latest
+        shell: bash
+
       - name: Check the code is good
+        if: runner.os == 'Linux'
         run: task check
 
       - name: Install protoc compiler
+        if: runner.os == 'Linux'
         uses: arduino/setup-protoc@v1
         with:
           repo-token: ${{ secrets.GITHUB_TOKEN }}
 
       - name: Check protocol buffers compile correctly
-        run: task protoc
+        if: runner.os == 'Linux'
+        run: task protoc:compile
 
       - name: Build the CLI
         run: task build

Diff for: Taskfile.yml

@@ -77,6 +77,13 @@ tasks:
       - npx {{ .PRETTIER }} --write "**/*.md"
 
   protoc:
+    desc: Lint, format and compile protobuf definitions
+    deps:
+      - protoc:check
+      - protoc:format
+      - protoc:compile
+
+  protoc:compile:
     desc: Compile protobuf definitions
     cmds:
       - '{{ default "protoc" .PROTOC_BINARY }} --proto_path=rpc --go_out=plugins=grpc,paths=source_relative:rpc ./rpc/cc/arduino/cli/commands/v1/*.proto'
@@ -92,6 +99,16 @@ tasks:
       - '{{ default "protoc" .PROTOC_BINARY }} --doc_out=./docs/rpc --doc_opt=markdown,settings.md --proto_path=rpc ./rpc/cc/arduino/cli/settings/v1/*.proto'
       - '{{ default "protoc" .PROTOC_BINARY }} --doc_out=./docs/rpc --doc_opt=markdown,debug.md --proto_path=rpc ./rpc/cc/arduino/cli/debug/v1/*.proto'
 
+  protoc:check:
+    desc: Perform linting of the protobuf definitions
+    cmds:
+      - buf lint rpc
+
+  protoc:format:
+    desc: Perform formatting of the protobuf definitions
+    cmds:
+      - clang-format -i rpc/cc/arduino/cli/*/*/*.proto
+
   build:
     desc: Build the project
     cmds:
@@ -134,6 +151,7 @@ tasks:
       - task: python:check
       - task: docs:check
       - task: config:check
+      - task: protoc:check
 
   config:check:
     desc: Check linting of configuration and supporting files

Diff for: rpc/buf.yaml

@@ -4,3 +4,5 @@ lint:
     ENUM_ZERO_VALUE_SUFFIX:
       - cc/arduino/cli/commands/v1/lib.proto
       - cc/arduino/cli/monitor/v1/monitor.proto
+    RPC_REQUEST_STANDARD_NAME:
+      - cc/arduino/cli/debug/v1/debug.proto