Skip to content

Some small refactoring on legacy package (part 2) #1079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 18, 2020
Merged

Some small refactoring on legacy package (part 2) #1079

merged 2 commits into from
Nov 18, 2020

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Nov 18, 2020

This is another refactoring of the legacy package.

As for #1064:

These are smaller/medium changes that are preparatory for other bigger PR.

I found myself juggling those small patches here and there in other branches, so I've decided to bite the bullet and put them in a smaller PR and merge them once for all.

Each commit has a self-contained change, they should be fairly easy to review.

@cmaglie cmaglie merged commit 5edef82 into arduino:master Nov 18, 2020
@cmaglie cmaglie deleted the legacy-removing-3 branch November 18, 2020 11:16
matthijskooijman
matthijskooijman reviewed Nov 18, 2020
View reviewed changes
Copy link
Collaborator

@matthijskooijman matthijskooijman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthijskooijman matthijskooijman matthijskooijman left review comments

@silvanocerza silvanocerza silvanocerza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cmaglie @matthijskooijman @silvanocerza