Some small refactoring on legacy package #1064
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prepares for building a compilation database later. The returned command is not currently used anywhere yet, so this commit should not change behaviour.
cmaglie
force-pushed
the
legacy-removing-2
branch
from
740d7d0 to
706d825
Compare
| @@ -189,22 +148,11 @@ func TrimSpace(value string) string { | |||
| } | |||
|
|
|||
| func PrepareCommand(pattern string) (*exec.Cmd, error) { | |||
| parts, err := ParseCommandLine(pattern) | |||
| parts, err := properties.SplitQuotedString(pattern, `"'`, false) | |||
There was a problem hiding this comment.
Would this change the behaviour of the compile command --build-property and --build-properties flags?
There was a problem hiding this comment.
No it should work exactly the same. This is code duplication that has never been removed.
(BTW a quick test would not be bad :-))
silvanocerza
approved these changes
Nov 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are smaller/medium changes that are preparatory for other bigger PR.
I found myself juggling those small patches here and there in other branches, so I've decided to bite the bullet and put them in a smaller PR and merge them once for all.
Each commit has an self-contained change, they should be fairly easy to review.
I've another batch of changes that sits on top of this PR.