Skip to content

Commit 5e61200

Browse files
committed
#1456 - Add optional dir field in the request, use it.
1 parent 269832b commit 5e61200

File tree

3 files changed

+31
-9
lines changed

3 files changed

+31
-9
lines changed

Diff for: commands/sketch/new.go

+6-1
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,12 @@ func CreateSketch(sketchDir string, sketchName string) (string, error) {
5050

5151
// NewSketch FIXMEDOC
5252
func NewSketch(ctx context.Context, req *rpc.NewSketchRequest) (*rpc.NewSketchResponse, error) {
53-
sketchesDir := configuration.Settings.GetString("directories.User")
53+
var sketchesDir string
54+
if len(req.SketchDir) > 0 {
55+
sketchesDir = req.SketchDir
56+
} else {
57+
sketchesDir = configuration.Settings.GetString("directories.User")
58+
}
5459
sketchDir := filepath.Join(sketchesDir, req.SketchName)
5560
sketchFile, err := CreateSketch(sketchDir, req.SketchName)
5661
if err != nil {

Diff for: rpc/cc/arduino/cli/commands/v1/commands.pb.go

+21-8
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: rpc/cc/arduino/cli/commands/v1/commands.proto

+4
Original file line numberDiff line numberDiff line change
@@ -288,6 +288,10 @@ message NewSketchRequest {
288288
Instance instance = 1;
289289
// New sketch name
290290
string sketch_name = 2;
291+
// Optional: create a sketch directory in this directory
292+
// (used as "sketches" directory), the directory must exist.
293+
// "directories.User" directory will be used otherwise.
294+
string sketch_dir = 3;
291295
}
292296

293297
message NewSketchResponse {

0 commit comments

Comments
 (0)