Skip to content

Q: how to create a new sketch via gRPC? #1456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
4ntoine opened this issue Sep 16, 2021 · 1 comment
Closed

Q: how to create a new sketch via gRPC? #1456

4ntoine opened this issue Sep 16, 2021 · 1 comment
Labels
type: enhancement Proposed improvement

Comments

@4ntoine
Copy link
Contributor

4ntoine commented Sep 16, 2021

Bug Report

Current behavior

No CreateSketch method in commands.proto, but there are LoadSketch and ArchiveSketch.

This is available with cmd arduino-cli sketch new ... so i guess it should be available via gRPC too.

Expected behavior

CreateSketch method in commands.proto.

Environment

  • CLI version (output of arduino-cli version): 0.19.0
  • OS and platform:

Additional context
@4ntoine 4ntoine changed the title Q: how to create a new sketch? Q: how to create a new sketch via gRPC? Sep 16, 2021
@silvanocerza silvanocerza added the type: enhancement Proposed improvement label Sep 20, 2021
4ntoine added a commit to 4ntoine/arduino-cli that referenced this issue Oct 6, 2021
@4ntoine
arduino#1456 - Update .proto
fe81896
4ntoine added a commit to 4ntoine/arduino-cli that referenced this issue Oct 6, 2021
@4ntoine
arduino#1456 - Regenerate .go classes
c0a95d7
4ntoine added a commit to 4ntoine/arduino-cli that referenced this issue Oct 6, 2021
@4ntoine
arduino#1456 - Extract sketch creating into command and use from CLI …
2f920b6 
…and gRPC
4ntoine added a commit to 4ntoine/arduino-cli that referenced this issue Oct 6, 2021
@4ntoine
arduino#1456 - Add a comment (fix code style)
62dff72
4ntoine added a commit to 4ntoine/arduino-cli that referenced this issue Oct 6, 2021
@4ntoine
arduino#1456 - Skip using tr() - requires translations.
4628846
4ntoine added a commit to 4ntoine/arduino-cli that referenced this issue Oct 6, 2021
@4ntoine
arduino#1456 - Adjust the comment (fix code style)
c82ff50
4ntoine added a commit to 4ntoine/arduino-cli that referenced this issue Oct 6, 2021
@4ntoine
arduino#1456 - Reformat (fix lint).
920a3e7
@4ntoine 4ntoine mentioned this issue Oct 6, 2021
Merged
5 tasks
4ntoine added a commit to 4ntoine/arduino-cli that referenced this issue Oct 11, 2021
@4ntoine
arduino#1456 - Add sketches directory to the Settings (to be used whe…
e6807b4 
…n called via gRPC)
4ntoine added a commit to 4ntoine/arduino-cli that referenced this issue Oct 12, 2021
@4ntoine
arduino#1456 - Add sketches directory to the Settings (to be used whe…
5a3a3aa 
…n called via gRPC)
4ntoine added a commit to 4ntoine/arduino-cli that referenced this issue Oct 12, 2021
@4ntoine
arduino#1456 - Add sketches directory to the Settings (to be used whe…
3384213 
…n called via gRPC)
4ntoine added a commit to 4ntoine/arduino-cli that referenced this issue Oct 12, 2021
@4ntoine
arduino#1456 - Add sketches directory to the Settings (to be used whe…
ca1ba0f 
…n called via gRPC)
4ntoine added a commit to 4ntoine/arduino-cli that referenced this issue Oct 12, 2021
@4ntoine
arduino#1456 - Use "diretories.User" dir instead of newly introduced …
c14718b 
…"directories.Sketches"
4ntoine added a commit to 4ntoine/arduino-cli that referenced this issue Oct 12, 2021
@4ntoine
arduino#1456 - Adjust code style
022268f
4ntoine added a commit to 4ntoine/arduino-cli that referenced this issue Oct 12, 2021
@4ntoine
arduino#1456 - Adjust i18n
14c2625
4ntoine added a commit to 4ntoine/arduino-cli that referenced this issue Oct 13, 2021
@4ntoine
arduino#1456 - Add "new sketch" in gRPC .proto, regenerate .pg.go. Us…
77e3f43 
…e "user" dir for sketches created via gRPC
4ntoine added a commit to 4ntoine/arduino-cli that referenced this issue Oct 13, 2021
@4ntoine
arduino#1456 - Add "new sketch" in gRPC .proto, regenerate .pg.go. Us…
53f3bf4 
…e "user" dir for sketches created via gRPC
4ntoine added a commit to 4ntoine/arduino-cli that referenced this issue Oct 14, 2021
@4ntoine
arduino#1456 - Avoid using hardcoded extension (address comment).
33d4d84
4ntoine added a commit to 4ntoine/arduino-cli that referenced this issue Oct 14, 2021
@4ntoine
arduino#1456 - Avoid using hardcoded extension (address comment).
d828bb4
4ntoine added a commit to 4ntoine/arduino-cli that referenced this issue Oct 14, 2021
@4ntoine
arduino#1456 - Avoid using hardcoded extension (address comment).
5a27b81
4ntoine added a commit to 4ntoine/arduino-cli that referenced this issue Oct 14, 2021
@4ntoine
arduino#1456 - Avoid using hardcoded extension (address comment).
10b7cac
4ntoine added a commit to 4ntoine/arduino-cli that referenced this issue Oct 14, 2021
@4ntoine
arduino#1456 - Avoid using hardcoded extension (address comment).
269832b
4ntoine added a commit to 4ntoine/arduino-cli that referenced this issue Oct 14, 2021
@4ntoine
arduino#1456 - Add optional dir field in the request, use it.
ef34dcb
4ntoine added a commit to 4ntoine/arduino-cli that referenced this issue Oct 14, 2021
@4ntoine
arduino#1456 - Add optional dir field in the request, use it.
5e61200
4ntoine added a commit to 4ntoine/arduino-cli that referenced this issue Oct 14, 2021
@4ntoine
arduino#1456 - Use go-paths-helper
98547d9
4ntoine added a commit to 4ntoine/arduino-cli that referenced this issue Oct 14, 2021
@4ntoine
arduino#1456 - Use go-paths-helper
45904d2
4ntoine added a commit to 4ntoine/arduino-cli that referenced this issue Oct 14, 2021
@4ntoine
arduino#1456 - Use go-paths-helper
cd49a5f
silvanocerza added a commit that referenced this issue Oct 15, 2021
@4ntoine @silvanocerza
Add gRPC function to create new Sketch (#1498)
ec376de 
* #1456 - Add "new sketch" in gRPC .proto, regenerate .pg.go. Use "user" dir for sketches created via gRPC

* #1456 - Avoid using hardcoded extension (address comment).

* #1456 - Add optional dir field in the request, use it.

* #1456 - Use go-paths-helper

* Use gRPC function from CLI to create new sketch

Co-authored-by: Silvano Cerza <[email protected]>
@silvanocerza
Copy link
Contributor

Solved by #1498.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@4ntoine @silvanocerza