#1456 - Avoid using hardcoded extension (address comment).

Author: 4ntoine

Diff for: cli/sketch/new.go

@@ -20,6 +20,7 @@ import (
 	"path/filepath"
 	"strings"
 
+	"github.com/arduino/arduino-cli/arduino/globals"
 	"github.com/arduino/arduino-cli/cli/errorcodes"
 	"github.com/arduino/arduino-cli/cli/feedback"
 	sk "github.com/arduino/arduino-cli/commands/sketch"
@@ -41,7 +42,7 @@ func initNewCommand() *cobra.Command {
 func runNewCommand(cmd *cobra.Command, args []string) {
 	// Trim to avoid issues if user creates a sketch adding the .ino extesion to the name
 	sketchName := args[0]
-	trimmedSketchName := strings.TrimSuffix(sketchName, ".ino")
+	trimmedSketchName := strings.TrimSuffix(sketchName, globals.MainFileValidExtension)
 	sketchDir, err := filepath.Abs(trimmedSketchName)
 	if err != nil {
 		feedback.Errorf(tr("Error creating sketch: %v"), err)

Diff for: commands/sketch/new.go

@@ -21,6 +21,7 @@ import (
 	"os"
 	"path/filepath"
 
+	"github.com/arduino/arduino-cli/arduino/globals"
 	"github.com/arduino/arduino-cli/commands"
 	"github.com/arduino/arduino-cli/configuration"
 	rpc "github.com/arduino/arduino-cli/rpc/cc/arduino/cli/commands/v1"
@@ -40,7 +41,7 @@ func CreateSketch(sketchDir string, sketchName string) (string, error) {
 		return "", err
 	}
 	baseSketchName := filepath.Base(sketchDir)
-	sketchFile := filepath.Join(sketchDir, baseSketchName+".ino")
+	sketchFile := filepath.Join(sketchDir, baseSketchName+globals.MainFileValidExtension)
 	if err := ioutil.WriteFile(sketchFile, emptySketch, os.FileMode(0644)); err != nil {
 		return "", err
 	}

Diff for: i18n/data/en.po

@@ -465,8 +465,8 @@ msgstr "Couldn't determine program size"
 msgid "Couldn't get current working directory: %v"
 msgstr "Couldn't get current working directory: %v"
 
-#: cli/sketch/new.go:32
 #: cli/sketch/new.go:33
+#: cli/sketch/new.go:34
 msgid "Create a new Sketch"
 msgstr "Create a new Sketch"
 
@@ -655,8 +655,8 @@ msgstr "Error creating output dir"
 msgid "Error creating sketch archive"
 msgstr "Error creating sketch archive"
 
-#: cli/sketch/new.go:47
-#: cli/sketch/new.go:52
+#: cli/sketch/new.go:48
+#: cli/sketch/new.go:53
 msgid "Error creating sketch: %v"
 msgstr "Error creating sketch: %v"
 
@@ -1978,7 +1978,7 @@ msgstr "Size (bytes):"
 msgid "Sketch cannot be located in build path. Please specify a different build path"
 msgstr "Sketch cannot be located in build path. Please specify a different build path"
 
-#: cli/sketch/new.go:56
+#: cli/sketch/new.go:57
 msgid "Sketch created in: %s"
 msgstr "Sketch created in: %s"