Skip to content

Core cache logging improvements #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 11, 2017
Merged

Core cache logging improvements #257

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ec9962
Print "archiving core" message at INFO level
matthijskooijman Dec 7, 2017
3dc280d
Show filename in "using precompiled core" message
matthijskooijman Dec 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/arduino.cc/builder/phases/core_builder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
package phases

import (
"os"
"path/filepath"

"arduino.cc/builder/builder_utils"
Expand Down Expand Up @@ -109,7 +108,7 @@ func compileCore(buildPath string, buildCachePath string, buildProperties proper
if canUseArchivedCore {
// use archived core
if verbose {
logger.Println(constants.LOG_LEVEL_INFO, "Using precompiled core")
logger.Println(constants.LOG_LEVEL_INFO, "Using precompiled core: {0}", targetArchivedCore)
}
return targetArchivedCore, variantObjectFiles, nil
}
Expand All @@ -128,7 +127,7 @@ func compileCore(buildPath string, buildCachePath string, buildProperties proper
// archive core.a
if targetArchivedCore != "" {
if verbose {
logger.Fprintln(os.Stdout, constants.LOG_LEVEL_DEBUG, constants.MSG_ARCHIVING_CORE_CACHE, targetArchivedCore)
logger.Println(constants.LOG_LEVEL_INFO, constants.MSG_ARCHIVING_CORE_CACHE, targetArchivedCore)
}
builder_utils.CopyFile(archiveFile, targetArchivedCore)
}
Expand Down