Core cache logging improvements #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This previously used the DEBUG level, which is shown in red by the Arduino IDE. Commit 7883e01 (Let "archiving core" message appear only if verbose) attempted to fix this, but did not. While here, this also changes Fprintln with an explicit Stdout argument to a regular Println, since Stdout is the default anyway. This commit properly fixes arduino#238. Signed-off-by: Matthijs Kooijman <[email protected]>
This is more consistent with other similar messages (e.g. "Using previously compiled file") and provides a direct hint to the user where this cached core can be deleted if needed. Signed-off-by: Matthijs Kooijman <[email protected]>
|
✅ Build completed. ⬇️ Build URL: ℹ️ To test this build:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two fairly trivial improvements to the log output concerning core caching.