Skip to content

I2S: Use 8 MHz oscillator source if 48MHz divider does not fit in 8 bits #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2018

Conversation

sandeepmistry
Copy link
Contributor

Fixes sketch from @andrewjfox in #310 (comment)

The divider can have a max resolution of 8-bits since we are using generator 3:

screen shot 2018-03-22 at 3 11 50 pm

These changes use the 8 MHz oscillator as the clock source instead of the 48 MHz DFLL if the divider can't fit in 8-bits.

@ArduinoBot
Copy link

✅ Build completed.

⬇️ Build URL: http://downloads.arduino.cc/PR/samd/package_samd-b190_index.json

ℹ️ To test this build:

  1. Open the Preferences of the Arduino IDE.
  2. Add the Build URL above in the Additional Boards Manager URLs field, and click OK.
  3. Open the Boards Manager (menu Tools->Board->Board Manager...)
  4. Install Arduino SAMD core - Pull Request I2S: Use 8 MHz oscillator source if 48MHz divider does not fit in 8 bits #317
  5. Select one of the boards under SAMD Pull Request I2S: Use 8 MHz oscillator source if 48MHz divider does not fit in 8 bits #317 in Tools->Board menu
  6. Compile/Upload as usual

@andrewjfox
Copy link

Just tested and getting correct clock freq for 8 bits @ 8kHz sampling

@sandeepmistry
Copy link
Contributor Author

@andrewjfox great, thanks for trying and your feedback!

@cmaglie cmaglie merged commit 09f867e into arduino:master Jul 31, 2018
@cmaglie cmaglie added this to the Release 1.6.20 milestone Jul 31, 2018
@cmaglie cmaglie deleted the fix-i2s-8bit-8kHz branch July 31, 2018 12:49
boseji pushed a commit to go-ut/combined-ArduinoCore-samd that referenced this pull request Jan 20, 2022
update bossac18 for neokey, neo, rotary, slide trinkey m0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants