LED_matrix: move _sequenceDone = true out of if block #42
Conversation
|
|
Sorry, I am trying to decide if I will sign such agreement, that one should probably have an attorney review it. Things like: "By signing in via GitHub acknowledge and agree that (A) your Contribution is your original work." What does "Original" mean? I simply fixed a problem in the current code base. Is that Original? But I will think about it. |
|
Signed, but may want to put a hold on this. Looks like the system picked up the updates to all of the links that had to be patched Will try to update it to just have the one file with the simple change |
Currently if you write a sketch that relies on knowing when a sequence completes, by having
your code call sequenceDone(), this will only work if your sketch sets a non-null callback function,
as the code that sets the condition is currently in the if block:
```
if(_callBack != nullptr){
```
Simply moved the line to after the if block
KurtE
force-pushed
the
led_matrix_sequence_done
branch
from
acc9e23 to
675c4db
Compare
|
Fixed to only update the one file |
|
Merged, thanks you very much! |
Currently if you write a sketch that relies on knowing when a sequence completes, by having your code call sequenceDone(), this will only work if your sketch sets a non-null callback function, as the code that sets the condition is currently in the if block:
Simply moved the line to after the if block