Skip to content

Commit acc9e23

Browse files
committed
LED_matrix: move _sequenceDone = true out of if block
Currently if you write a sketch that relies on knowing when a sequence completes, by having your code call sequenceDone(), this will only work if your sketch sets a non-null callback function, as the code that sets the condition is currently in the if block: ``` if(_callBack != nullptr){ ``` Simply moved the line to after the if block
1 parent 80faaf8 commit acc9e23

File tree

9 files changed

+9
-9
lines changed

9 files changed

+9
-9
lines changed

Diff for: cores/arduino/IRQManager.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
#define SDCARD_DMA_REQ_PRIORITY 10
1212
#define SDCARD_CARD_PRIORITY 12
1313
#define EXTERNAL_PIN_PRIORITY 12
14-
#define UART_SCI_PRIORITY 12
14+
#define UART_SCI_PRIORITY 6 //12
1515
#define USB_PRIORITY 12
1616
#define AGT_PRIORITY 14
1717
#define RTC_PRIORITY 12

Diff for: cores/arduino/api

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
../../../ArduinoCore-API/api/
1+
d:/github/ArduinoCore-API/api

Diff for: cores/arduino/tinyusb/class

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
../../../extras/tinyusb/src/class/
1+
C:/users/kurte/documents/arduino/hardware/arduino-dev/renesas/extras/tinyusb/src/class/

Diff for: cores/arduino/tinyusb/common

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
../../../extras/tinyusb/src/common/
1+
C:/users/kurte/documents/arduino/hardware/arduino-dev/renesas/extras/tinyusb/src/common/

Diff for: cores/arduino/tinyusb/device

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
../../../extras/tinyusb/src/device/
1+
C:/users/kurte/documents/arduino/hardware/arduino-dev/renesas/extras/tinyusb/src/device/

Diff for: cores/arduino/tinyusb/host

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
../../../extras/tinyusb/src/host
1+
C:/users/kurte/documents/arduino/hardware/arduino-dev/renesas/extras/tinyusb/src/host

Diff for: cores/arduino/tinyusb/osal

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
../../../extras/tinyusb/src/osal/
1+
C:/users/kurte/documents/arduino/hardware/arduino-dev/renesas/extras/tinyusb/src/osal/

Diff for: cores/arduino/tinyusb/rusb2

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
../../../extras/tinyusb/src/portable/renesas/rusb2/
1+
C:/users/kurte/documents/arduino/hardware/arduino-dev/renesas/extras/tinyusb/src/portable/renesas/rusb2/

Diff for: libraries/Arduino_LED_Matrix/src/Arduino_LED_Matrix.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -175,8 +175,8 @@ class ArduinoLEDMatrix {
175175
}
176176
if(_callBack != nullptr){
177177
_callBack();
178-
_sequenceDone = true;
179178
}
179+
_sequenceDone = true;
180180
}
181181
memcpy(framebuffer, (uint32_t*)frame, sizeof(frame));
182182
}

0 commit comments

Comments
 (0)