fix for https://github.com/arduino/ArduinoCore-renesas/issues/12 #31
Conversation
|
|
| @@ -403,16 +426,24 @@ void ArduinoSPI::configSpiSci(arduino::SPISettings const & settings) | |||
| uint32_t smr = R_SCI0_SMR_CM_Msk; | |||
|
|
|||
| /* Configure CPHA setting. */ | |||
| spmr |= (uint32_t) clk_phase << 7; | |||
| uint32_t mask = (ONE_BIT << SCI_CKPH_POS); | |||
| spmr &= ~(uint32_t)mask; // reset bit 0 | |||
There was a problem hiding this comment.
Is this comment // reset bit 0 true? It looks to me like its copy and paste from the baud rate generator clock divider configuration.
|
|
||
| /* Configure CPOL setting. */ | ||
| spmr |= (uint32_t) clk_polarity << 6; | ||
| mask = (ONE_BIT << SCI_CKPOL_POS); |
There was a problem hiding this comment.
I'm not really happy with the generic ONE_BIT, TWO__BITS defines. Maybe consider using the FSP layer provided constants, i.e.
-mask = (ONE_BIT << SCI_CKPOL_POS);
+mask = (SPI_CLK_POLARITY_HIGH << SCI_CKPOL_POS);? This one's a matter of taste though.
|
Superseded by #13 |
|
I think this should be reopened since it fixes additional problems I didn't catch in my PR: clearing the mode and bit order bits so you can revert back if talking to multiple devices, and applies the same fixes to configSpiSci. |
| @@ -374,23 +385,35 @@ void ArduinoSPI::configSpi(arduino::SPISettings const & settings) | |||
| uint32_t spcmd0 = _spi_ctrl.p_regs->SPCMD[0]; | |||
There was a problem hiding this comment.
I wonder if it would be clearer to just modify the register in-place to make use of Renesas' struct definitions, so all of the masking and bit shifting would be handled implicitly. Like so:
auto& spcmd0 = _spi_ctrl.p_regs->SPCMD_b[0]; // note SPCMD_b not SPCMD
spcmd0.CPHA = clk_phase;
spcmd0.CPOL = clk_polarity;
spcmd0.LSBF = bit_order;
spcmd0.BRDV = spck_div.brdv;
| @@ -403,16 +426,24 @@ void ArduinoSPI::configSpiSci(arduino::SPISettings const & settings) | |||
| uint32_t smr = R_SCI0_SMR_CM_Msk; | |||
There was a problem hiding this comment.
Likewise, maybe this could be:
auto& spmr = _spi_sci_ctrl.p_reg->SPMR_b;
spmr.CKPH = clk_phase;
spmr.CKPOL = clk_polarity;
auto& scmr = _spi_sci_ctrl.p_reg->SCMR_b;
scmr.SDIR = bit_order;
auto& smr = _spi_sci_ctrl.p_reg->SMR_b;
smr.CKS = clk_div.cks;
|
Superseded by #45 . |
Tone: fix infinite duration
Tone: fix infinite duration Former-commit-id: edbcbd3
fix for #12