Fix SPI mode and bit order settings #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I verified the fix using an ADXL345, and it works! |
|
Thank you so much for the fix! |
maidnl
pushed a commit
that referenced
this pull request
Jul 4, 2023
Refactor SPI module a bit (configuration code especially).
cristidragomir97
pushed a commit
to cristidragomir97/ArduinoCore-renesas
that referenced
this pull request
May 20, 2024
Refactor SPI module a bit (configuration code especially). Former-commit-id: d29cb4e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#12
The logical not in this line makes the mask 0 and wipes out the earlier settings. This should be a bitwise not, but even so the
0xFFwould also mask off the SSLA bits b6-b4 and half of the SPB bits b9-b8. Changing0xFFto3will clear just the BRDV bits b3-b2.