-
-
Notifications
You must be signed in to change notification settings - Fork 212
Improve SFU for Nano RP2040 OTA #237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changeset contains also the Nina Pin changes. Is this intentional?
Nope, removing 🙂 |
9849575
to
5a0a695
Compare
@@ -7,7 +7,7 @@ const unsigned char SFU[0x10000] __attribute__ ((section(".second_stage_ota"), u | |||
#include "rp2040.h" | |||
}; | |||
|
|||
FlashIAPBlockDevice bd(XIP_BASE + 0x100000, 0x100000); | |||
FlashIAPBlockDevice bd(XIP_BASE + 0xF00000, 0x100000); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to have this as a static object within SFU (and therefore always on the RAM)? I'd just keep it as a local variable as done here https://github.com/arduino-libraries/ArduinoIoTCloud/pull/257/files#diff-09aa9693675d970be15fa987b65d99e65812b4e32924fe48fce8d3f87bcd6f99R65 (Beware, I don't know if this works).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we can indeed move it in the function or even in SFU::begin(), not sure we can see many improvements but it's worth trying
Memory usage change @ 5a0a695
Click for full report table
Click for full report CSV
|
5a0a695
to
916c818
Compare
916c818
to
96f23a1
Compare
Memory usage change @ 96f23a1
Click for full report table
Click for full report CSV
|
No description provided.