INITIAL: support OTA on Nano RP2040 Connect #256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #256 +/- ##
=======================================
Coverage 95.15% 95.15%
=======================================
Files 24 24
Lines 867 867
=======================================
Hits 825 825
Misses 42 42 Continue to review full report at Codecov.
|
…or samd architecture).
In the current implementation if the OTA process fails (no reset) then the thread started to kick the watchdog timer would run forever. This does defeat the purpose of the watchdog which is only supposed to be kicked within ArduinoIoTCloud.update(). It should be enough to strategically sprinkle watchdog calls throughout the code.
In the early days of OTA development the SFU was used to perform a application update using a binary stored on an external SPI flash. However, this method was discarded, because it would have required for the users to purchase a MKR MEM shield additionally to their connected board. Therefore it is safe to remove the manual SFU defines from above which prevents any name collissions with the (unfortunately nambed) Nano RP2040 Connect SFU.
… -> download binary.
…herwise we might loop forever in case no data becomes available any more.
… has never been completed and may need a complete overhaul, mofe SFU into nano specific OTA module.
…it might happen that the connection has been terminated by the server, although not all available data has been read from the NINA.
…t makes sense to feed the watchdog within the main-loop body since the timeout will terminate the loop anyway.
… (makes error handling easier - see next step).
…n (debug message, fclose, return error)
|
|
…unted file-format - now we can be super sure to have a clean set-up. https://os.mbed.com/docs/mbed-os/v6.11/mbed-os-api-doxy/classmbed_1_1_f_a_t_file_system.html#a6bb5160b6665359b9411ebc65aaa5308
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs this patch over mbed core.