Correct duplicate filter inversion #476
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scanning with duplicates should disable the filter, scanning without duplicates should enable the filter.
This was referenced Mar 15, 2017
sgbihu
reviewed
Mar 16, 2017
| @@ -578,7 +578,7 @@ BLEDevice BLEDeviceManager::peripheral() | |||
|
|
|||
| bool BLEDeviceManager::startScanning() | |||
| { | |||
| _adv_duplicate_filter_enabled = false; | |||
There was a problem hiding this comment.
I don't think you can change code here. If you changed code here, it will make developer confusing. I think change the code in BLEDevice.cpp is more reasonable.
|
I was actually expecting scan(true) to turn on the duplicate filter so you see devices only once. Is the following the correct behavior? |
|
system test passed |
SidLeung
added a commit
to SidLeung/corelibs-arduino101
that referenced
this pull request
Mar 22, 2017
Bug fixed: This feature was implemented in PR arduino#457, merged, and released in Deneb.RC1. However, it was discovered that the logic was inverted and was report as Git issue arduino#476. BLE scan() and input parameter withDuplicates is true means reporting all Peripherals detected regardless how many times it was reported. Code mods: 1. libraries/CurieBLE/src/BLEDevice.cpp: - In startScan, calls the correct routine to scan for all Peripherals if withDuplicates is true. Otherwise, just scan for new ones. 2. libraries/CurieBLE/src/BLEDevice.h: - Prototyping. 3. libraries/CurieBLE/src/internal/BLEDeviceManager.h, libraries/CurieBLE/src/internal/BLEDeviceManager.cpp - Modified header comment to reflect the input parameter withDuplictes correct meaning. - Default the input parameter, withDupilcates, as true. - And, consequently, eliminated some redundant methods.
SidLeung
added a commit
to SidLeung/corelibs-arduino101
that referenced
this pull request
Mar 22, 2017
Bug fixed: This feature was implemented in PR arduino#457, merged, and released in Deneb.RC1. However, it was discovered that the logic was inverted and was report as Git issue arduino#476. BLE scan() and input parameter withDuplicates is true means reporting all Peripherals detected regardless how many times it was reported. Code mods: 1. libraries/CurieBLE/src/BLEDevice.cpp: - In startScan, calls the correct routine to scan for all Peripherals if withDuplicates is true. Otherwise, just scan for new ones. 2. libraries/CurieBLE/src/BLEDevice.h: - Prototyping. 3. libraries/CurieBLE/src/internal/BLEDeviceManager.h, libraries/CurieBLE/src/internal/BLEDeviceManager.cpp - Modified header comment to reflect the input parameter withDuplictes correct meaning. - Default the input parameter, withDupilcates, as true. - And, consequently, eliminated some redundant methods.
SidLeung
added a commit
to SidLeung/corelibs-arduino101
that referenced
this pull request
Mar 22, 2017
Bug fixed: This feature was implemented in PR arduino#457, merged, and released in Deneb.RC1. However, it was discovered that the logic was inverted and was report as Git issue arduino#476. BLE scan() and input parameter withDuplicates is true means reporting all Peripherals detected regardless how many times it was reported. Code mods: 1. libraries/CurieBLE/src/BLEDevice.cpp: - In startScan, calls the correct routine to scan for all Peripherals if withDuplicates is true. Otherwise, just scan for new ones. 2. libraries/CurieBLE/src/BLEDevice.h: - Prototyping. 3. libraries/CurieBLE/src/internal/BLEDeviceManager.h, libraries/CurieBLE/src/internal/BLEDeviceManager.cpp - Modified header comment to reflect the input parameter withDuplictes correct meaning. - Default the input parameter, withDupilcates, as true. - And, consequently, eliminated some redundant methods.
|
This PR is replaced by the following PR, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scanning with duplicates should disable the filter, scanning without duplicates should enable the filter.
Related to #368.